pMusic 6.0.0

Audio editors, music players, video players, burning software, etc.
Message
Author
User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1321 Post by 01micko »

zigbert wrote:Mick
The tooltips in pEqualizer is fixed - version 0.8.2

Download pMusic 3 - Beta2 here
yep, saw that :)

I do have a strange issue after I index my files.Not too many on this disc, maybe 15 albums. Best to see the pic. I played the AC/DC file by clicking on it so that is why that one is there I guess.

BTW, that is after clicking Music sources >> My Music >> My Tracks
Attachments
pmusic-296.png
(57.56 KiB) Downloaded 524 times
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1322 Post by zigbert »

Mick
No good
How does you index file look? - /root/.pmusic/index_mymusic (or where you have pointed the data storage).
The numbers are timestamps that are written to index file when song is completed. I see that pMusic is wrinting to index file even if song is NOT in index.

I have added an extra check in func_player line 232

Code: Select all

	if grep false $WORKDIR/stop > /dev/null && ! grep -F 'error' $WORKDIR/aplay_error; then 
		#RATING: User has listen through the complete song, add to rating index
		TMP="`grep -F "${PLAYLIST}|" "$STORAGE_DIR/index_mymusic"`"
		if [ "$TMP" ]; then
			#place the last played track at top of index to get into Overview - see this
			echo "${TMP},`date +%s`" > $WORKDIR/tmp_rating
			grep -vF "${PLAYLIST}|" "$STORAGE_DIR/index_mymusic" >> $WORKDIR/tmp_rating
			mv -f $WORKDIR/tmp_rating "$STORAGE_DIR/index_mymusic"
		fi



Download pMusic 3 - Beta2 here
Last edited by zigbert on Fri 02 Nov 2012, 06:05, edited 1 time in total.

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1323 Post by 01micko »

/root/.pmusic/index_mymusic only has the timestamps by the look. This one is a bit over my head!
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1324 Post by zigbert »

Somehow the indexing must have gone wrong. Can you try to reproduce it.

The index file contains 21 fields. ie. like this:

Code: Select all

/mnt/home/mp3_streamripper/DMR_Metal_Canada_128/Within Temptation - Lost.mp3|Within Temptation|Lost|The Unforgiving|9|2011|||0|mp3 |128|05:05||/mnt/home/mp3_streamripper/DMR_Metal_Canada_128/Within Temptation - Lost.mp3||4e93ba92-212d-4ed4-83a8-cf520f978b88|eace2373-31c8-4aba-9a5c-7bce22dd140a|http://lyricwiki.org/Within_Temptation:Lost|/mnt/sdb1/musikk/pmusic storage/albumart/Within Temptation - The Unforgiving.jpg||,1351427237,1351427956,1351428368,1351429065,1351430480,1351431261,1351433294,1351434136,1351437287,1351637968,1351638276
Thank you
Sigmund



Download pMusic 3 - Beta2 here

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1325 Post by 01micko »

Ok, with nothing playing, I add my music path which is /mnt/sda10/music to the gui with the + button. I delete /root and /mnt with - button (they are there by default). I index, the progress looks normal but the /root/.pmusic/index_mymusic file ends up empty. I think the file is building ok but at the finish it gets overwritten by something.

Clicking tracks and playing them adds entries to that file. Is that supposed to happen?

Radio database works normally.

Each time I am deleting /root/.pmusic so I start with a clean slate.

-----

I just stepped back to 2.9.4 and it works as expected indexing my tracks.
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1326 Post by zigbert »

Ok Mick, I am diving.

But first 2 things to mention:

The trayapp is no longer included in the pMusic pet because pMusic belongs in the noarch category - taryapp doesn't. It is available via plugins. Atm, plugin structure is simple, but that will change if we see more use of it.

The detection of correct soundcard should be less Puppy specific with this code. If content of /etc/asound.conf doesn't return any value, use the first card.

Code: Select all

#Detect active soundcard
if [ "$SOUND_DEVICE" = "auto" ]; then
	if [ -f /etc/asound.conf ]; then #see if MultipleSoundCardWizard was used
		TMP=$(head -1 /etc/asound.conf)
		CARD_NR=${TMP##* } 
	fi
	if [ ! "$CARD_NR" ]; then
		TMP="`aplay -l | grep -m 1 -F card`" #grab the first card
		CARD_NR="`echo $TMP | cut -d':' -f1 | cut -d' ' -f2`"
	fi
else
	CARD_NR="`echo $SOUND_DEVICE | cut -d':' -f1 | cut -d' ' -f2`"
fi

Download pMusic 3 - Beta3 here
Last edited by zigbert on Fri 02 Nov 2012, 07:34, edited 1 time in total.

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1327 Post by zigbert »

Mick
I think I got it


Download pMusic 3 - Beta3 here

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1328 Post by zigbert »

pMusic 3 Beta4


Download pMusic 3 - Beta4 here

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1329 Post by 01micko »

2.9.7

:D
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1330 Post by zigbert »

Great Mick.

If you want to include tray-app in the distro just install this pet. It is the 32bit version.


Download pMusic 3 - Beta4 here

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1331 Post by 01micko »

Hi Sigmund,

The tray app is already there. I have been using the separate pet throughout slacko-beta testing but since the pmusic-3 beta series started it fails to work. I didn't dive in though, it is probably something simple missing. If I start the tray app with /usr/local/pmusic/pmusic_tray I can start pmusic from the tray app..

Cheers
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1332 Post by zigbert »

You must use the latest trayapp pet. Only this one is compatible with pMusic 3. All trayapp-specific code is removed in favor to the new plugin structure. The new pet contains both the tray icon and an rc file that holds plugin information.


Sigmund


Download pMusic 3 - Beta4 here

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1333 Post by 01micko »

Ok, apologies.. I got the pet but there is still a problem. The icon doesn't show for me. It seems it ignores the rc file for icon path as it's hard coded in the C source to /usr/local/pmusic/pmusic20.png

Code: Select all

pmusic_pixbuf=gdk_pixbuf_new_from_file("/usr/local/pmusic/pmusic20.png",&gerror);
Ok.. that file exists.. but it is a broken symlink to somewhere on your system!

Code: Select all

# readlink pmusic20.png
/mnt/sdb1/prioritet 1/privat/prg/bash/pmusic/plugins/pmusic_tray-0.1-x86_32/usr/share/icons/hicolor/22x22/apps/pmusic.png
so... I'll make a link to a relative icon and see how it goes :wink: (will work then)
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1334 Post by zigbert »

>>> :oops: <<<

Fixed link and uploaded again



Download pMusic 3 - Beta4 here
Last edited by zigbert on Fri 02 Nov 2012, 10:06, edited 1 time in total.

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1335 Post by zigbert »

The trayapps are compiled in Slacko (32bit) and Fatdog (64bit). I have assumed that they will work also in other systems. You know the compiling world - can it work?


Sigmund



Download pMusic 3 - Beta4 here

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1336 Post by 01micko »

zigbert wrote:The trayapps are compiled in Slacko (32bit) and Fatdog (64bit). I have assumed that they will work also in other systems. You know the compiling world - can it work?


Sigmund



Download pMusic 3 - Beta4 here
There is absolutely no problem with the tray app.. it's the packaging that is at fault. :wink:

Firstly, remove the symlink from your tray-app pets, it's wrong and overwrites the good one leaving a stale symlink.

Secondly, the symlink which I presume is supposed to be /usr/local/pmusic/pmusic20.png is missing from the 2.9.7 package. Oh, I just discovered that the /usr/share/icons/hicolor/22x22/apps/pmusic.png is missing from the pmusic-2.9.7 package. The only reason my icons were in tact before the addition of the newly packaged tray-app is I have been overwriting since pmusic-2.6.6.

However... the svg icon looks nicer in the tray 8) ... you can decide how you want to fix it :) .. a link to pmusic20 from the svg icon works for the tray but not for menu.. maybe you can put the absolute path in the DOTdesktop file to /usr/share/icons/hicolor/22x22/apps/pmusic.png and make a relative symlink like this at the top level of the package to the svg icon for the tray.

Code: Select all

(cd usr/local/pmusic;ln -sf ../../share/icons/hicolor/scalable/apps/pmusic.svg pmusic20.png)
Mick
Attachments
pmusic20-snap.png
(21.7 KiB) Downloaded 1048 times
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1337 Post by zigbert »

the symlink which I presume is supposed to be /usr/local/pmusic/pmusic20.png is missing from the 2.9.7 package
pMusic 3 does not require /usr/local/pmusic/pmusic20.png or /usr/share/icons/hicolor/22x22/apps/pmusic.png, so I have removed it from the pMusic pet. Instead I added it to the tray-pet. But to be 'smart' I moved the icon to /usr/share/icons and left a symlink back in /usr/local/pmusic. This might be in conflict with pMusic 2, but in a fresh install, it should work ok.

I didn't know trayapps could use svg. That's great.
The best solution would of course be to rewrite trayapp to look directly for /usr/share/icons/hicolor/scalable/apps/pmusic.svg. The reason for not doing this is that I have not been able to run a 64bit system, so I can't compile it.


Sigmund

User avatar
01micko
Posts: 8741
Joined: Sat 11 Oct 2008, 13:39
Location: qld
Contact:

#1338 Post by 01micko »

zigbert wrote: The best solution would of course be to rewrite trayapp to look directly for /usr/share/icons/hicolor/scalable/apps/pmusic.svg. The reason for not doing this is that I have not been able to run a 64bit system, so I can't compile it.
Already onto it.. I'll boot fatdog later and do 64 :wink:

File includes adjusted source code.
Attachments
pmusic_trayapp-files-32.tar.bz2
(4.38 KiB) Downloaded 678 times
Puppy Linux Blog - contact me for access

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1339 Post by zigbert »

You are such a good guy!!!!!
Can I give you a hug :D

User avatar
zigbert
Posts: 6621
Joined: Wed 29 Mar 2006, 18:13
Location: Valåmoen, Norway
Contact:

#1340 Post by zigbert »

And yes, I see....
...Because of the jwm-menu, we need /usr/share/icons/hicolor/22x22/apps/pmusic.png in the pMusic pet.
And I have changed the icon setting in the .desktop file

I will upload a new one.


Download pMusic 3 - Beta5 here

Post Reply