Author |
Message |
scabz

Joined: 30 Apr 2009 Posts: 366 Location: Tallahassee FL US
|
Posted: Sat 15 Dec 2012, 23:55 Post subject:
|
|
the problems i had above was that the ffmpeg i had was bad, i compiled ffmpeg 1.0 and all works well now. Sorry for the bad report.
|
Back to top
|
|
 |
01micko

Joined: 11 Oct 2008 Posts: 8670 Location: qld
|
Posted: Sun 16 Dec 2012, 03:20 Post subject:
|
|
Sigmund
Small Christmas present for you (in time for 3.1?).
I figured out how to toggle the icon for pause/play in the tray app, very simple really once I realised all you do is switch the icons for the main gui, of course the tray app can use it too. About one minute's work after I realised.
Attached is a tarball containing the 32 bit binary and the source code. Seems working ok for me.
Cheers
Attachment removed, see later post.
_________________ Puppy Linux Blog - contact me for access
Last edited by 01micko on Sun 16 Dec 2012, 08:01; edited 1 time in total
|
Back to top
|
|
 |
zigbert

Joined: 29 Mar 2006 Posts: 6541 Location: Valåmoen, Norway
|
Posted: Sun 16 Dec 2012, 05:33 Post subject:
|
|
That's great Mick
I have updated plugin thread - Try app
pMusic 3.1 is a bit further into the future. It require updates of gtkdialog and probably ffmpeg. Being on the dependency-edge is a good place to be for the developer, but not the best place for the user, so I plan to wait until at least gtkdialog-0.8.3 settles.
Thanks a lot
Sigmund
_________________ Stardust resources
|
Back to top
|
|
 |
01micko

Joined: 11 Oct 2008 Posts: 8670 Location: qld
|
Posted: Sun 16 Dec 2012, 06:14 Post subject:
|
|
Ok, so we wait some for 3.1
One thing about the new tray icon, the icon needs to be in a fixed path for the C code so it is hard coded to "/root/.pmusic/tmp/icon_playpause.png". "$HOME" doesn't work. This makes it unfriendly to multiuser systems. I'll have a think about how to get around this in the future, so it may be wise to keep the older version available for multiuser systems for now.
_________________ Puppy Linux Blog - contact me for access
|
Back to top
|
|
 |
zigbert

Joined: 29 Mar 2006 Posts: 6541 Location: Valåmoen, Norway
|
Posted: Sun 16 Dec 2012, 07:03 Post subject:
|
|
Mick
Would it help if $WORKDIR was set in the rc-file or in a separate file?
Sigmund
_________________ Stardust resources
|
Back to top
|
|
 |
01micko

Joined: 11 Oct 2008 Posts: 8670 Location: qld
|
Posted: Sun 16 Dec 2012, 08:01 Post subject:
|
|
zigbert wrote: | Mick
Would it help if $WORKDIR was set in the rc-file or in a separate file? |
Not likely as $HOME could be /root, /home/johnny or /home/mary on any one system.
However, I came up with a quick and dirty work around. Seems to work ok. When the tray app is initialised it creates a symlink to $HOME/.pmusic/tmp/icon_playpause.png in /tmp. Now the C code looks for that . Simplest way I could think of and I tested by deleting $HOME/.pmusic. I didn't test as a multiuser but it's not hard coded now so should be ok.
Attached.
EDIT: also compiled in FatDog, first attachment, no source (same as 32 src)
Description |
64 bit binary. BE CAREFUL, it's not in a sub folder of it's own. You could easy mix them up.
|

Download |
Filename |
pmusic_trayapp-64bit-161212.tar.bz2 |
Filesize |
3.51 KB |
Downloaded |
311 Time(s) |
Description |
includes 32 bin and source
|

Download |
Filename |
pmusic-trayapp-161212-2ND.tar.bz2 |
Filesize |
4.79 KB |
Downloaded |
311 Time(s) |
_________________ Puppy Linux Blog - contact me for access
|
Back to top
|
|
 |
zigbert

Joined: 29 Mar 2006 Posts: 6541 Location: Valåmoen, Norway
|
Posted: Sun 16 Dec 2012, 09:18 Post subject:
|
|
Trayapp updated !!!!
Great stuff
Sigmund
_________________ Stardust resources
|
Back to top
|
|
 |
scabz

Joined: 30 Apr 2009 Posts: 366 Location: Tallahassee FL US
|
Posted: Mon 17 Dec 2012, 16:30 Post subject:
|
|
one issues i am having in when clicking on the smart add button and click add if there is less tracks in the folder then the number set it frezzez when adding to the playlist.
another thing i miss the add all button that was in older pmusic.
|
Back to top
|
|
 |
L18L
Joined: 19 Jun 2010 Posts: 3431 Location: www.eussenheim.de/
|
Posted: Tue 18 Dec 2012, 08:15 Post subject:
Pmusic 3.0.6 Subject description: fix |
|
Quote: | # pmusic
/usr/local/pmusic/pmusic: line 51: [: 3.0.6: integer expression expected
|
fixed line 51 wrote: | [ "`grep -F VERSION $CONFIG | cut -d= -f2 | cut -d. -f1`" -lt 3 ] && rm -f $WORKDIR/* |
|
Back to top
|
|
 |
L18L
Joined: 19 Jun 2010 Posts: 3431 Location: www.eussenheim.de/
|
Posted: Tue 18 Dec 2012, 12:16 Post subject:
|
|
01micko wrote: | ... so it is hard coded to "/root/.pmusic/tmp/icon_playpause.png". "$HOME" doesn't work. This makes it unfriendly to multiuser systems.... |
Thanks to mcewanw I recall that ~ is equivalent to $HOME
/usr/bin/pavrecord line 28 wrote: | export PROGRAMHOME=~/.${PROGRAMNAME} |
Hope that helps but some testing is needed
|
Back to top
|
|
 |
zigbert

Joined: 29 Mar 2006 Posts: 6541 Location: Valåmoen, Norway
|
Posted: Tue 18 Dec 2012, 18:54 Post subject:
Re: Pmusic 3.0.6 Subject description: fix |
|
L18L wrote: | [ "`grep -F VERSION $CONFIG | cut -d= -f2 | cut -d. -f1`" -lt 3 ] && rm -f $WORKDIR/* | Got it - Thank you
Sigmund
_________________ Stardust resources
|
Back to top
|
|
 |
zigbert

Joined: 29 Mar 2006 Posts: 6541 Location: Valåmoen, Norway
|
Posted: Tue 18 Dec 2012, 18:58 Post subject:
|
|
scabz wrote: | one issues i am having in when clicking on the smart add button and click add if there is less tracks in the folder then the number set it frezzez when adding to the playlist.
another thing i miss the add all button that was in older pmusic. | I can't reproduce this bug. Hmmm..... More info ?
I'll consider a new 'Add all' function.
Sigmund
_________________ Stardust resources
|
Back to top
|
|
 |
L18L
Joined: 19 Jun 2010 Posts: 3431 Location: www.eussenheim.de/
|
Posted: Wed 19 Dec 2012, 14:24 Post subject:
Re: Pmusic 3.0.6 Subject description: fix for fix |
|
zigbert wrote: | L18L wrote: | [ "`grep -F VERSION $CONFIG | cut -d= -f2 | cut -d. -f1`" -lt 3 ] && rm -f $WORKDIR/* | Got it - Thank you
Sigmund |
This will be valid only up to version 9
But there is ever valid vercmp
# vercmp
usage: vercmp version1 lt|gt|le|ge|eq version2
return value 0 if true, else 1
#
--
edit
link to vercmp: http://bkhome.org/blog/?viewDetailed=02226
|
Back to top
|
|
 |
01micko

Joined: 11 Oct 2008 Posts: 8670 Location: qld
|
Posted: Fri 21 Dec 2012, 07:43 Post subject:
|
|
L18L wrote: | 01micko wrote: | ... so it is hard coded to "/root/.pmusic/tmp/icon_playpause.png". "$HOME" doesn't work. This makes it unfriendly to multiuser systems.... |
Thanks to mcewanw I recall that ~ is equivalent to $HOME
/usr/bin/pavrecord line 28 wrote: | export PROGRAMHOME=~/.${PROGRAMNAME} |
Hope that helps but some testing is needed | Yeah, nice idea, had my doubts though and were confirmed. Oh well, thanks for trying.
_________________ Puppy Linux Blog - contact me for access
|
Back to top
|
|
 |
zigbert

Joined: 29 Mar 2006 Posts: 6541 Location: Valåmoen, Norway
|
Posted: Tue 25 Dec 2012, 18:19 Post subject:
|
|
Version 3.0.7
See main post
Changelog
- Bugfix: Detection of installed pMusic older than version 3.0.0 (thanks to L18L)
_________________ Stardust resources
|
Back to top
|
|
 |
|