Variable inside a function? [SOLVED]

[Argolance]

Bonjour,
How to make the variable "DEF_APP" to work inside this function?
Example:

Code: Select all

#!/bin/sh

export DEF_APP="myapp"

func_defaultapp () {

	Xdialog --title "$(gettext 'Installation') - $(gettext 'Information')" icon /usr/local/lib/X11/pixmaps/question.png --stdout --yesno "$(gettext 'Do you want this application to be set as default?')" 0 0

	case $? in
		0)echo '#!/bin/sh
		
exec $DEF_APP "$@"' > /root/defaultapptest
		;;
		1)Xdialog --title "$(gettext 'Installation') - $(gettext 'Information')" --no-buttons --infobox "$(gettext 'Canceled...')" 3 50
		;;
		255)Xdialog --title "$(gettext 'Installation') - $(gettext 'Information')" --no-buttons --infobox "$(gettext 'Canceled...')" 3 50
		;;
	esac
}
export -f func_defaultapp

func_default

I get:

Code: Select all

#!/bin/sh
		
exec $DEF_APP "$@"

And would like to get:

Code: Select all

#!/bin/sh
		
exec myapp "$@"

Ouch! The variables...
Thank you!

Cordialement.

[SFR]

Single quotes prevent variables from being expanded:

Code: Select all

# var=123; echo 'something $var blahblah'
something $var blahblah
# var=123; echo 'something '$var' blahblah'
something 123 blahblah
# 

This should work:

Code: Select all

exec '$DEF_APP' "$@"' > /root/defaultapptest 

Greetings!

[Argolance]

Hello, I found the (a) solution:

Code: Select all

#!/bin/bash

export DEF_APP="myapp"

func_defaultapp () {

	Xdialog --title "$(gettext 'Installation') - $(gettext 'Information')" icon /usr/local/lib/X11/pixmaps/question.png --stdout --yesno "$(gettext 'Do you want this application to be set as default?')" 0 0

	case $? in
		0)echo "#!/bin/sh
		
exec $DEF_APP \"\$@\""> /root/defaultapptest
		;;
		1)Xdialog --title "$(gettext 'Installation') - $(gettext 'Information')" --no-buttons --infobox "$(gettext 'Canceled...')" 3 50
		;;
		255)Xdialog --title "$(gettext 'Installation') - $(gettext 'Information')" --no-buttons --infobox "$(gettext 'Canceled...')" 3 50
		;;
	esac
}
export -f func_defaultapp

func_defaultapp

Question: This works but is this right?
Thanks.

Cordialement.

[Argolance]

... This works (too) and seems to be more "kosher"!
Thanks.

Cordialement.