(old)Puppy Linux Discussion Forum

It appears that pfind can't get a listing of ALL files in folder recursively.

I am able to get what I want with the following command The user would right click on a folder, Click on "Advanced" and
click on "Complete file list (of current)"

If the advanced window had a button to generate a text file
with this info it would useful.

Or maybe it could be a menu item in the front pfind window??

______________________________________

don570 wrote:Suggestion: To save about an inch of width I suggest using icons
rather than text. A tooltip pop up to give the name of the icon
would be nice to avoid confusion.

Yes, that would be good. But with the extra line for "Total" on your picture, is the window short enough for small screens?

It appears that pfind can't get a listing of ALL files in folder recursively.

Can't you just search for * ?
It used to work.

don570
Sometimes we agree - sometimes we don't.....
.... This time we could probably agree if
- The icons was good-looking
- The icons shows some logic information
- The icons was very small in kb
- The icons was very small in pixel-size. As disciple mention, we have a screen-height to fit inside. I measured my gui to 475 pixels tall....


Sigmund

zigbert wrote:

disciple wrote:Hopefully I'll remember to check it out when I get home this weekend.

Please do, and report back.
I have started to knock down some bugs in pFilesearch.


Sigmund

It is great for me, but I think it might be a bit clunky for a lot of people. Or perhaps it isn't working quite right on my machine. Can you please confirm if it is working as intended?
1. When I run an advanced search the pfind window updates to display the results. But the pfilesearch window stays on top! I imagine it would be fairly easy to raise the pfind window using something like xdotool.
2. If I close the pfind window while the pfilesearch window is open, pfilesearch stays open. And if I then run a search in pfilesearch, it doesn't reopen a pfind window or anything to display the results. (I guess this would be trickier to fix - you wouldn't want to close all pfilesearch windows when you close a pfind window, only the one spawned by it.)
3. If I click the advanced button again, I get a new advanced window. If possible I think people would prefer this to raise the first pfilesearch window... but I guess raising the correct pfilesearch window might be a little difficult. And it is kind of cool controlling the same pfind window from more than one pfilesearch window

It might be better to put the total at top rather than bottom
because the word "TOTAL' (if it was a text tag) could be
located more definitely and not move about depending on
font size.

By the way I got the icons out of standard puppy locations
(mostly mini-icons ) but I made modified the document
and the video icons to make them white.

_______________________________________________

Jemimah wants her apps to fit in 400 pixel height
because of some mini laptop she has.

________________________________________

I spotted this when opening a script with pfind
(using a double click or using the menu).

The link is used rather than the actual file so
geany has the strange heading (see image)

This is very confusing, but I discovered that the actual file
is opened and can be modified.
It would be better if the real path of file was used.



_______________________________________________

disciple wrote:It is great for me, but I think it might be a bit clunky for a lot of people.

Got it, working on another approach. Need to restructure some code.....

don570 wrote:I spotted this when opening a script with pfind
(using a double click or using the menu).

The link is used rather than the actual file so
geany has the strange heading (see image)

This is very confusing, but I discovered that the actual file
is opened and can be modified.
It would be better if the real path of file was used.

Noted. Will look at it. Thank you

Just a note to those who have reported bugs - we are still not there yet. First we need to settle how this script should work. Then there will come more restructuring of the code - then we will see more bugs - then it's time to bugfix.....

zigbert wrote:

don570 wrote:I spotted this when opening a script with pfind
(using a double click or using the menu).

The link is used rather than the actual file so
geany has the strange heading (see image)

This is very confusing, but I discovered that the actual file
is opened and can be modified.
It would be better if the real path of file was used.

Noted. Will look at it. Thank you

Not as easy as I first thought..... thinking......

Next attempt is to embed pfilesearch into Pfind.
There are pros and cons also with this solution..... What is your opinion?









You need to install both pets to get things going.

I prefer some type of 'Popping up' action to get the
info about a file like CTRL-I or a tooltip popup because I
was trained on an Apple Macintosh but right clicks
make sense as well. Your latest pmusic interface is good.

Over the weekend the idea struck me that you should try to
crunch as much instructions and buttons in the top portion
of the Pfind window as possible and that would let the bottom
half of window to be the name and path.

The 'Calculate Total' would simply tell the user the total
number of hits (if he's interested in this info)'

The total button could be eliminated to save room by making it
a menu item. I see from your work over weekend that you have
choosen a notebook widget arrangement which is fine
however it requires an extra line or two of space, so
a menu item would be the better choice if possible

Here's the mock up. There is no 'Search' button to save space
but the window title could have the instruction 'Tap ENTER'.
And the red arrow down would be the advanced button.
The combobox saves quite a bit of space over the Radio button
widget.



...and here I show the 'Total' menu item.

Note that when 'Show all results' if chosen by user the
application would exit and then relaunch with all the results
shown in bottom of window. I don't think the user would
notice this if he had a fast machine.

don570
Thank you for your ideas, and that you take the time to build mockups of them. In particular I like your alternative combobox for 'Where to search'. Depending on the final gui, this could give a cleaner gui.

I will put Pfind on hold for some days, so that everyone gets the time to enlighten us. Let's not rush into some it-kind-of-works gui.


Thank you
Sigmund

Another idea....

When the user right clicks on a folder and selects 'Search inside'
why not have an alternate script for pfind called 'pfind_foldersearch'

This script could be nearly line for line the same as your 'pfind' script
and located in /usr/local/pfind/ as well. It would be able to share
the local folder translations.

The one difference would be the default value of the combobox,
since the default selection would be 'Current directory' rather
than a System search.

I could make a Rox right-click link back to the script 'pfind_foldersearch'

______________________________________________________

Frankly I didn't like your notebook idea. Your previous version was better.

____________________________________________________

Have you tried It looks cool

__________________________

don570
Rox right-click is meant to be built in Pfind.pet, but failed in these test builds..... Should be fixed.

Frankly I didn't like your notebook idea. Your previous version was better.

Thank you for mention it.

Here you get a new one.....

Hopefully a bit closer to something good....

Got it
Onto bugfixing

Version 5.0 is uploaded
See main post

changelog 5.0
- Rewritten GUI
- Show find command (thanks to Sit Heel Speak)
- Move locales to /usr/share/locale/
- Removed the switches -o and -a
- Removed search-group; Mail
- Bugfix: Search inside folder (from rox) made 'where to search' buttons to not work. (thanks to don570)
- Bugfix: Sort by extension if filename ends with space or if filename lacks '.'. (thanks to disciple)
- NLS: Added: LOC_HITS, 103, 712, 900
- NLS: Changed: LOC109, 151, 152, 153, 154, 402, 403, 405, 406, 407, 408, 409, 613, 618
- NLS: Removed: LOC110, 112, 130, 131, 132, 133, 314, 315, 316, 401, 404, 410, 607, 608, 619, 710, 800, 801

I made Bulldog finder compatible with Thunar and the Saluki distribution

http://murga-linux.com/puppy/viewtopic. ... 879#629879

________________________________________________________________