Page 3 of 8

Posted: Wed 28 Jul 2010, 14:34
by jpeps
It looks like the script posts "Firewall On" if rc.firewall is present, even if $MODULE has been removed, or am I missing something?

edit: If so, one way would be to check the presence of iptable in loaded mods.

Posted: Wed 28 Jul 2010, 15:37
by tasmod
No, quite simple really.

It was meant for a first run tray applet for new Puplets. Just to remind you to turn on the firewall by running the wizard.

So a new Puppy install would show as 'firewall off' and the option to run the wizard as a reminder in the tooltip. That's why I added the quit and remove.

Now, when you have a clean install the rc.local file has no entry for firewall. When you run the wizard it appends the 'firewall start' script instruction there. I just check for that script. i don't check for the rc.firewall.

In effect once the firewall wizard is run it should not need changing. However, if you wish to turn it off then alter the script to show 'firewall stop' not 'firewall start'

Posted: Wed 28 Jul 2010, 16:07
by tasmod
OK, I see your point.

But the tray applets first intention wasn't to be a full time app, however i did change it subject to requests, so i suppose it had better be accurate in it's reporting.

I've just done a couple of experiments both loading and unloading modules.

My simple method will change state if the text is changed but not reflect an accurate actual change until rebooted.

Unloading the module has no effect on the script so firewallstate will be inaccurate.

I will experiment with code to look at running the lsmod output to a file and parse that checking for iptables.

Posted: Wed 28 Jul 2010, 16:51
by jpeps
I'd be happy with a simple entry on the info page, along with the other cats.

edit: firewall start/stop switch?

Posted: Wed 28 Jul 2010, 19:53
by tasmod
Hmmm, I've carried out further tests.

The only way to turn the firewall off easily is to change the text in rc.local to 'firewall stop' and reboot. Otherwise delete the rc.firewall and reboot again.
All require a reboot and the rc.local changes, so I can't see a reason to change the code at the moment. Unless anyone knows otherwise.

I have changed the code and tested but it is easier the original way as this seems to be universal in operation.

I wrote a pet to turn firewall on and off a while back, it's on here somewhere.

Posted: Thu 29 Jul 2010, 03:29
by jpeps
tasmod wrote:Hmmm, I've carried out further tests.

The only way to turn the firewall off easily is to change the text in rc.local to 'firewall stop' and reboot. Otherwise delete the rc.firewall and reboot again.
All require a reboot and the rc.local changes, so I can't see a reason to change the code at the moment. Unless anyone knows otherwise.

I have changed the code and tested but it is easier the original way as this seems to be universal in operation.

I wrote a pet to turn firewall on and off a while back, it's on here somewhere.

hm...looks like it works

Code: Select all

/etc/rc.d # ./rc.firewall stop
-> Projectfiles.com Linux Firewall version 2.0rc9 running.
-> Performing sanity checks. [ PASSED ]
-> Firewall disabled.

/etc/rc.d # ./rc.firewall start
-> Projectfiles.com Linux Firewall version 2.0rc9 running.
-> Performing sanity checks...... [ PASSED ]
-> Building firewall.... [ DONE ]
-> Successfully secured the following addresses: 192.168.1.112.

Posted: Thu 29 Jul 2010, 09:21
by tasmod
I wrote the original pet to do just that.

I was setting up a router and network and kept getting weird results due to the firewall. So I quickly wrote the script and gui to turn it on and off whilst I carried out tests.
Zigbert incorporated in his all encompassing setup program.

I suppose I could incorporate it in the app along with a menu launch entry if you want.

Posted: Thu 29 Jul 2010, 17:59
by jpeps
tasmod wrote:I wrote the original pet to do just that.

I suppose I could incorporate it in the app along with a menu launch entry if you want.
Could be useful, and then the "firewall on(off)" message could simply be connected to the switch.

Posted: Thu 29 Jul 2010, 20:41
by 8-bit
Just what does a person need to change in rc.firewall to allow network printing to bypass the firewall?
The reason I ask is that if I set up the firewall accepting default, shared printers are not seen by linux guest systems.

Posted: Fri 30 Jul 2010, 07:25
by tasmod
I'm no expert on the firewall but:

Try running the firewall wizard and use arrow key to scroll down and select custom.

Try enabling print spooler using spacebar as advised in tips.

Posted: Fri 30 Jul 2010, 07:58
by 01micko
8-bit wrote:Just what does a person need to change in rc.firewall to allow network printing to bypass the firewall?
The reason I ask is that if I set up the firewall accepting default, shared printers are not seen by linux guest systems.
In the custom section I put "631/tcp" .. seemed to work :? .. I can print puppy machine to puppy machine. Enabled some of the other things too. Forget exactly. Patriot would know or rcrsn51.

Cheers

Posted: Fri 30 Jul 2010, 09:46
by tasmod
OK, back on the code.

After testing I found the app would work for most users 100% but if a user used my on/off app or a cli command then it wouldn't reflect the status.

This is because the commands work direct with rc.firewall and do not write to the rc.local to reflect the change in realtime.

So code changed and checks lsmod for ip_tables at jpeps suggestion. (thanks)

Edit: removed icon code request. Now working.

Posted: Fri 30 Jul 2010, 13:57
by chrome307
This seems to be working good for me, remains in the taskbar as I wanted :)

Thanks for this app!

Posted: Fri 30 Jul 2010, 14:01
by tasmod
Thanks for the feedback, much appreciated.

Version 1.3 posted, works regardless of commands issued elsewhere.
Incorporates ON/OFF in menu, should you need it.

Regarding the External IP address info. It's been interesting seeing my external IP change occasionally by BT.

Posted: Fri 30 Jul 2010, 14:07
by chrome307
@tasmod

I'm using v1.2 .... hadn't realised you'd updated it again!!

lol ... I even used it to correct my location settings for time!!

Posted: Fri 30 Jul 2010, 14:10
by tasmod
Hmm, that's a thought, I could make a menu call to my Psync time server setting app as it's included in Lucid puppy.

Posted: Fri 30 Jul 2010, 15:39
by jpeps
Looking good! Thanks

Posted: Sat 31 Jul 2010, 00:03
by bigpup
tasmod,

Version 1.3 working 100%.
Thanks for making a good program into a great program. Your willingness to make changes and improvements, based on input from others, is really a tribute to you. This should be added to every Puppy version as a must have feature!

Posted: Sat 31 Jul 2010, 17:14
by tasmod
Thanks bigpup much appreciated.

-----

Version 1.4 released

I think this is probably the last version as the menu is now a bit large and I don't want to encroach on the main menu system.

I've added the 3 options for settings as reported in Information on menu.
I've also added Psync for accurate time setting.

Posted: Sat 31 Jul 2010, 19:16
by jpeps
tasmod wrote:Thanks bigpup much appreciated.

-----

Version 1.4 released

I think this is probably the last version as the menu is now a bit large and I don't want to encroach on the main menu system.

I've added the 3 options for settings as reported in Information on menu.
I've also added Psync for accurate time setting.
I agree there's something to be said about keeping things simple. Psync, set time & date, etc., are already readily available in desktop settings. "Choose keyboard layout" doesn't work, but is available through Choose Country. (I think most of this gets set up initially anyway during first bootup).