No Desktop Icon for reiserfs formatted partition [SOLVED]

[norgo]

Recently I booted Slacko-6.3.0 from a Flash-drive on a computer with a reiserfs formatted partition on it's HDD.
I was wondering that there was no drive icon at the desktop for this partition.
Some time ago I remastered a Slacko-5.6.0 live CD for this computer and haven't had this problem.

The HDD of my Laptop contains also a reiserfs formatted partition and so I've a computer for testing.

Here the results:
Slacko 5.6.0 : drive icon present
Precise 5.7.1: drive icon present
Slacko 6.3.0 : no drive icon
Tahrpup 6.0.5 : no drive icon

I had a look into /usr/local/pup_event/frontend_* and compared these by which of Slacko 5.6.0 but couldn't find a reason.

Somebody an idea for this behave of Slacko 6.3.0 and Tahrpup 6.0.5 ? ( other versions not tested yet )

Btw. pMount is showing the reiserfs partition and it's no problem to mount/unmount and to read data from it.
probepart is detecting the partition too.
Here the output:

Code: Select all

# probepart
/dev/sda1|ext3|1026048
/dev/sda2|swap|1028096
/dev/sda3|ext3|61945856
/dev/sda4|reiserfs|170433584
/dev/sdb1|vfat|1048576
/dev/sdb2|ext3|14206976
#

[bigpup]

In Tahrpup 6.0.5 the support tools for reiserfs were missing.
I installed them from the Puppy Package Manager (PPM).
Drive icon now shows on desktop.
Gparted can now use reiserfs format.

You need to install this tool package from PPM reiserfsprogs

In PPM do a search for reiserfsprogs to find it in PPM.

EDIT:
That worked until I rebooted.
Now the desktop drive icon is not showing after a reboot.
Pmount does still see and mount the reiserfs partition.

Nothing ends up being simple with computers

[norgo]

Thank you @bigpup for quick response,

unfortunately installation of reiserfsprogs didn't solve the problem.
Okay now it's possible to create or change reiserfs partitions using GParted but this wasn't my goal.
Slacko 5.6.0 hasn't installed reiserfsprogs by default and it's working nevertheless.

So I had once again a look at the frontend scripts in /usr/local/pup_event and think that I found the reason for the behave of Slacko 6.3.0 and Tahrpup 6.0.5.
Maybe you could have a look at this.

In the frontend scripts of Slacko 5.6.0 you can read in create_icon_func commands like:

#show all drives on desktop... w476 add ext4... 130216 add f2fs...
PROBEPART="`probepart -k | grep -E '\|f2fs\||\|ext4\||\|ntfs\||\|msdos\||\|vfat\||\|ext2\||\|ext3\||\|iso9660\||\|udf\||\|audiocd\||\|xfs\||\|reiser'`"

or

#display an icon for each partition... w476 add ext4... 130216 add f2fs...
[ ! $1 ] && PROBEPART="`probepart -k | grep -E '\|f2fs\||\|ext4\||\|ntfs\||\|msdos\||\|vfat\||\|ext2\||\|ext3\||\|iso9660\||\|udf\||\|audiocd\||\|xfs\||\|reiser'`"

All extended expressions have the format |filesystem| except the last entry.
The latest entry has an "open end".

In newer Distributions has been added a new entry |none| at the end.
Here a snippet of Slacko 6.3.0 as example
#display an icon for each partition... w476 add ext4... 130216 add f2fs...
[ ! $1 ] && PROBEPART="`probepart -k | grep -E '\|f2fs\||\|ext4\||\|ntfs\||\|msdos\||\|vfat\||\|ext2\||\|ext3\||\|iso9660\||\|udf\||\|audiocd\||\|xfs\||\|reiser\||\|none'`"

Now the |reiser| pattern has to match exactly.

At first the probepart output of my Laptop

Code: Select all

#probepart

/dev/sda1|ext3|1026048
/dev/sda2|swap|1028096
/dev/sda3|ext3|61945856
/dev/sda4|reiserfs|170433584

Now the 1st test containing reiser at the end of expressions ( open end )

Code: Select all

#probepart | grep -E '\|ext3\||\|swap\||\|reiser'

/dev/sda1|ext3|1026048
/dev/sda2|swap|1028096
/dev/sda3|ext3|61945856
/dev/sda4|reiserfs|170433584

grep is showing the line containing reiserfs
and would show everything beginning with |reiser
In this case you would get an icon at your desktop for a reiserfs formatted partition.

The 2nd test is containing reiser in the middle of expressions

Code: Select all

#probepart | grep -E '\|ext3\||\|reiser\||\|swap'

/dev/sda1|ext3|1026048
/dev/sda2|swap|1028096
/dev/sda3|ext3|61945856

grep doesn't show the line containing reiserfs because |reiser| doesn't match |reiserfs|
In this case you wouldn't get an icon at your desktop.
Small cause, large effect.

Now there are two solutions.
1st one is to move the reiser expression at the end of line ( baddish )
2nd one is to replace reiser by reiserfs and reiser4

Attached changed scripts and diffs.
Cheers!

[LazY Puppy]

What about to change reiser just to reiser*?

Could this solve the issue?

[bigpup]

norgo,

You need to submit this change to Woof CE so it can be put into future Puppies.
Have you submitted these changes to Woof-CE?

If you really want this to get into Puppy, the code is there in Woof-CE.
https://github.com/puppylinux-woof-CE/woof-CE
Make a pull request to submit to Woof CE.

There is also this:
woof-CE patch generator!
http://www.murga-linux.com/puppy/viewtopic.php?t=98740

[norgo]

@bigpup

Already done

jlst and mavrothal did this for me.
Woof-CE test brunch contains now these changes.

Nevertheless thank you for the hint.