Puppy Linux Discussion Forum Forum Index Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Wed 26 Apr 2017, 12:05
All times are UTC - 4
 Forum index » Off-Topic Area » Programming
Building a universal file viewer
Post new topic   Reply to topic View previous topic :: View next topic
Page 3 of 8 [114 Posts]   Goto page: Previous 1, 2, 3, 4, 5, 6, 7, 8 Next
Author Message
some1

Joined: 17 Jan 2013
Posts: 70

PostPosted: Wed 08 Feb 2017, 03:16    Post subject:  

MochiMoppel:
I just noticed,that I was too much in a hurry when I wrote and posted the code above.
See the Edit.
---
I have done some testing on vanilla Tahr and Slacko539 - both on 2 "puppy-machines" i.e. 500MB and 1 GB.
The result was as described previously.
I have no solutions -
except some user-rules based on my experience -
1) dont sort
2) dont go into /proc - basically we have no business there
3) avoid using the keyboard-arrows in dirs with big-files.
BIG-files will load slowly and if big enough crash the gui.
That goes for Geany too - so its mostly a matter of getting
accustomed to having a quickview,when travelling a filelist.
NORTON Commander -Remember that?
'------
I think your script is much more than the gui.
The integration/hookup with rox gives a lot of power/choice.
Nice project.
Back to top
View user's profile Send private message 
dejan555


Joined: 30 Nov 2008
Posts: 2794
Location: Montenegro

PostPosted: Wed 08 Feb 2017, 05:36    Post subject:  

some1 wrote:

3) avoid using the keyboard-arrows in dirs with big-files.
BIG-files will load slowly and if big enough crash the gui.


Use head to load only x lines of text files for preview?
Like, top 100?

_________________
Dpup 487 | Puppy Gallery | My photo gallery | mtPaint works
Back to top
View user's profile Send private message Visit poster's website MSN Messenger 
peebee


Joined: 21 Sep 2008
Posts: 2668
Location: Worcestershire, UK

PostPosted: Wed 08 Feb 2017, 08:14    Post subject:  

Nice initiative....

Doubling clicking an item with spaces in the file name gives errors.....

Replacing rox by defaultfilemanager (2 places) cures this problem (on LxPupSc-17.02.1 with pcmanfm)

Cheers!
peebee

_________________
LxPup = Puppy + LXDE
Back to top
View user's profile Send private message Visit poster's website 
MochiMoppel


Joined: 26 Jan 2011
Posts: 1246
Location: Japan

PostPosted: Wed 08 Feb 2017, 08:56    Post subject:  

dejan555 wrote:
But then it wouldn't show the center of image by default but top-left corner and you would need to scroll for the rest
No, this is perfect! Thank you! Here is what I will use for the next update:
Code:
<hbox scrollable="true" space-expand="true">
  <pixmap>
  ...
  </pixmap>
</hbox>


@some1
I tested your proposal and it worked. I only had to add a missing refresh:vPMAP2 and I deleted the width-request="'$PR_X'" height-request="'$PR_Y'" stuff because it causes the pixmap to "spill out" of its frame (you will understand what I mean when you resize the window).

The idea certainly is clever and probably the best tweak possible considering the limits of the pixmap widget, but weighing all pros and cons I find too many cons. My biggest objection is that the scaling is not dynamic (e.g as in Viewnior) and that it has not clue how big or small the viewer pane really is, so the code may scale down an image even when the viewer pane could easily accommodate the original size. Nevertheless other members might reach different conclusions. I attach a very barebone test script which will show your tweak in action. Maybe this could also serve as the barebone template you proposed.

Quote:
3) avoid using the keyboard-arrows in dirs with big-files.

clicking on them is not any better Wink

What you really should avoid is using the LEFT and RIGHT arrow keys. They let you switch between the leftmost Places pane and the main files list... if you are lucky.
Make a test:
    1) in QuickView go to /usr/local (just as an example) and press the close button
    2) Restart QuickView. You should now be in /usr/local again.
    3) Press the LEFT key
    The Search box opens. This makes it not only impossible to switch back to the file list, it's even worse: the list is gone. The user might not remember were he came from.
    4) Now click on left "File system" and go to /usr/local. Try LEFT key again. It will take you to "File system" in Places pane, not the Search box. That's the way it should be.
Somehow chooser needs a know how a file/folder in the main file list is related to the Places items. Chooser "remembers" this when the selection starts in Places but it can't make this connection when it is thrown right into a directory with the <default> tag.

Peebee wrote:
Doubling clicking an item with spaces in the file name gives errors.....

*Which* errors? Spaces in file names shouldn't be a problem, but if you don't use rox then of course the script may not work properly.
mm_quickview_imagescaling_test.gz
Description  Remove fake gz extension
THIS IS A STRIPPED DOWN VERSION FOR THE SOLE PURPOSE TO TEST
IMAGE RELATED CODE. NO FURTHER UPDATES, NO BUG FIXES.
gz

 Download 
Filename  mm_quickview_imagescaling_test.gz 
Filesize  4.52 KB 
Downloaded  25 Time(s) 

Last edited by MochiMoppel on Thu 09 Feb 2017, 20:19; edited 1 time in total
Back to top
View user's profile Send private message 
vovchik


Joined: 23 Oct 2006
Posts: 1377
Location: Ukraine

PostPosted: Wed 08 Feb 2017, 09:23    Post subject:  

Dear MochiMoppel,

I just tried your latest. It's great for viewing and is even fast on my relatively slow machine. Great work and nice improvment. Thanks.

With kind regards,
vovchik
Back to top
View user's profile Send private message 
smokey01


Joined: 30 Dec 2006
Posts: 2514
Location: South Australia

PostPosted: Wed 08 Feb 2017, 21:38    Post subject:  

MM nice little script, works well. I have one concern though. Each time a file is touched the filename is bolded and the date of the file is changed to the current date. I like to keep the original dates on my photos and other files.
_________________
Software <-> Distros <-> Tips <-> Newsletters
Back to top
View user's profile Send private message Visit poster's website 
MochiMoppel


Joined: 26 Jan 2011
Posts: 1246
Location: Japan

PostPosted: Wed 08 Feb 2017, 23:43    Post subject:  

smokey01 wrote:
Each time a file is touched the filename is bolded
bothers me too..
Quote:
and the date of the file is changed to the current date.
Well, only the "access" and "change" timestamps are changed, not the important "modified" timestamp. So far I regarded it more as a nuisance, to be fixed on a rainy day when everything else is fixed.

Now that you mentioned it I investigated and found the culprit. The behavior is caused in the fill_statusbar function by the -p option of the file command:
    MIME=$(file --separator " │ " -ip "$vCHOOSER" 2>&1)
    if [[ "$MIME" = *│*x-symlink* ]];then
    echo -n $vCHOOSER " ➡" $(file --separator " │ " -ip "$(realpath "$vCHOOSER")" 2>&1)

I used this option because I thought it would preserve the existing file dates
The manual wrote:
-p, --preserve-date        preserve access times on files
It obviously means that the time of access by the command is preserved with a new timestamp ... on files, not of files. Sorry, lost in translation. I will update the script.
Back to top
View user's profile Send private message 
greengeek


Joined: 20 Jul 2010
Posts: 4534
Location: New Zealand

PostPosted: Thu 09 Feb 2017, 02:41    Post subject:  

Hi Mochi - I am using the latest version and wondered the following:

- is there any way to set it for single click rather than double click? If I single click on an image or text file it displays ok immediately but if I single click on a directory it does not open - requiring me to doubleclick. Is this related to rox settings? Is it possible for this behaviour to be modified (or modifiable) within mmviewer regardless of how rox is set?

- is it possible to set mmviewer so that it slightly alters the display format of text files so that they have a leading space in the display panel? Xml files display in a nice readable way because they tend to have plenty of leading spaces and tabs - but flat text files seem crammed up against the left margin of the viewer and are harder to read for someone like me who suffers from astigmatism.

cheers!
Back to top
View user's profile Send private message 
MochiMoppel


Joined: 26 Jan 2011
Posts: 1246
Location: Japan

PostPosted: Thu 09 Feb 2017, 03:45    Post subject:  

greengeek wrote:
- is there any way to set it for single click rather than double click?
No.
Quote:
- is it possible to set mmviewer so that it slightly alters the display format of text files so that they have a leading space in the display panel?
I've now changed <edit> to <edit left-margin="0"> . Set a higher value to add margin.
Back to top
View user's profile Send private message 
peebee


Joined: 21 Sep 2008
Posts: 2668
Location: Worcestershire, UK

PostPosted: Thu 09 Feb 2017, 05:09    Post subject:  

MochiMoppel wrote:
Peebee wrote:
Doubling clicking an item with spaces in the file name gives errors.....

*Which* errors? Spaces in file names shouldn't be a problem, but if you don't use rox then of course the script may not work properly.

If you could consider changing rox to defaultfilemanager then that would be appreciated - thanks.

I would like to include this facility in the next LxPupSc.....
Screenshot.png
 Description   
 Filesize   121 KB
 Viewed   160 Time(s)

Screenshot.png


_________________
LxPup = Puppy + LXDE
Back to top
View user's profile Send private message Visit poster's website 
smokey01


Joined: 30 Dec 2006
Posts: 2514
Location: South Australia

PostPosted: Thu 09 Feb 2017, 05:27    Post subject:  

I knew you could do it.

MochiMoppel wrote:
smokey01 wrote:
Each time a file is touched the filename is bolded
bothers me too..
Quote:
and the date of the file is changed to the current date.
Well, only the "access" and "change" timestamps are changed, not the important "modified" timestamp. So far I regarded it more as a nuisance, to be fixed on a rainy day when everything else is fixed.

Now that you mentioned it I investigated and found the culprit. The behavior is caused in the fill_statusbar function by the -p option of the file command:
    MIME=$(file --separator " │ " -ip "$vCHOOSER" 2>&1)
    if [[ "$MIME" = *│*x-symlink* ]];then
    echo -n $vCHOOSER " ➡" $(file --separator " │ " -ip "$(realpath "$vCHOOSER")" 2>&1)

I used this option because I thought it would preserve the existing file dates
The manual wrote:
-p, --preserve-date        preserve access times on files
It obviously means that the time of access by the command is preserved with a new timestamp ... on files, not of files. Sorry, lost in translation. I will update the script.

_________________
Software <-> Distros <-> Tips <-> Newsletters
Back to top
View user's profile Send private message Visit poster's website 
smokey01


Joined: 30 Dec 2006
Posts: 2514
Location: South Australia

PostPosted: Thu 09 Feb 2017, 05:27    Post subject:  

The forum is misbehaving. Caused me to double post.
_________________
Software <-> Distros <-> Tips <-> Newsletters
Back to top
View user's profile Send private message Visit poster's website 
MochiMoppel


Joined: 26 Jan 2011
Posts: 1246
Location: Japan

PostPosted: Thu 09 Feb 2017, 08:10    Post subject:  

peebee wrote:
If you could consider changing rox to defaultfilemanager then that would be appreciated
Not by many people Laughing The script would stop to work. No major Puppy knows "defaultfilemanager". My script also uses rox options which I don't expect to work with any other file manager.

Instead may I suggest that you fix your scripts. You are not using ROX-Filer and the error message in your screenshot is not triggered by ROX-Filer. In your case the command rox "$vCHOOSER" , which of course works fine with the "real" ROX, calls a wrapper script which points to pcmanfm. You need to use proper quoting in this script .... or you could simple symlink to defaultfilemanager, where you did the quoting right, hence no problems with defaultfilemanager.
Back to top
View user's profile Send private message 
dejan555


Joined: 30 Nov 2008
Posts: 2794
Location: Montenegro

PostPosted: Thu 09 Feb 2017, 17:56    Post subject:  

Just an idea, how about using xdg-open instead rox?
Would the resulting behavior stay the same?

EDIT: Just tried the new version and big images are now scaled down and small images stay normal, that's awesome!

_________________
Dpup 487 | Puppy Gallery | My photo gallery | mtPaint works
Back to top
View user's profile Send private message Visit poster's website MSN Messenger 
Geoffrey


Joined: 30 May 2010
Posts: 2257
Location: Queensland

PostPosted: Thu 09 Feb 2017, 18:58    Post subject:  

peebee wrote:
MochiMoppel wrote:
Peebee wrote:
Doubling clicking an item with spaces in the file name gives errors.....

*Which* errors? Spaces in file names shouldn't be a problem, but if you don't use rox then of course the script may not work properly.

If you could consider changing rox to defaultfilemanager then that would be appreciated - thanks.

I would like to include this facility in the next LxPupSc.....


The X series of pups have a modified rox file in /usr/local/bin that uses exo-open, maybe this will give you a clue to make something workable.
Code:
#!/bin/sh
# redirect rox calls to thunar

CURRENTWM="`cat /etc/windowmanager`"

if [ "$CURRENTWM" = "jwm" ]; then
  exec /usr/local/apps/ROX-Filer/AppRun "$@"
else
  if [ $# -eq 0 ];then
    exo-open /root
    exit
  fi
  if [ "$1" = "-D" ];then
    exit
  fi
  if [ "$3" = "-d" ] || [ "$3" = "-x" ];then
   exo-open "$2"
   exit
  fi
  if [ "$1" = "-d" ];then
    shift
    exo-open "$@"
    exit
  fi 
  if [ -d "$1" ];then
    exo-open "$@"
    exit
  fi
fi


_________________
Carolina: Recent Repository Additions
Create strikethrough text HERE

Back to top
View user's profile Send private message 
Display posts from previous:   Sort by:   
Page 3 of 8 [114 Posts]   Goto page: Previous 1, 2, 3, 4, 5, 6, 7, 8 Next
Post new topic   Reply to topic View previous topic :: View next topic
 Forum index » Off-Topic Area » Programming
Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.0970s ][ Queries: 14 (0.0054s) ][ GZIP on ]