Puppy Linux Discussion Forum

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

New version again, I tried to make a sfs but I couldn't get it to load over the main sfs so I repacked it as a pet with just the AppDir and desktop file. This one will not overwrite any settings, but should not be used for woof builds.
Edit: Newer versions posted later.

I was able to fix the "copy/paste" functionality. The problem was that the clipboard was "set" during initialization instead of when actually doing a "copy" or "cut", so it would stop working as soon as another program used the clipboard. Once I moved the "set" function to the proper place the strange behavior stopped.

For debugging I wrote some scripts that use xclip to copy and paste from the command line, I don't know if anyone else might find them useful?

g-copy

Puppyt · Joined: 09 May 2008 Posts: 854 Location: Gatton, Queensland

Thanks so much woodenshoe-wi - rox column management active in TahrPup64 6.0.6. Was rehashing an old grumble on a recent thread, and your pet has salved a sore point in Rox usability. Cheers!
Re: How do I modify ROX detail columns?

UPDATE: Sorry, I have to qualify my test as a partial success only. I haven't tested copy'n'paste which I see was your main concern with your patch. However, I got a bit giddy with the detail view column change functionality, which in my TahrPup64 version had been locked into a useless Name/Permissions/Owner/Group/Type/Size/Last modified... format. Who needs Permissions/Owner/Group in Puppy??? Wish there was some way to eliminate those columns entirely.
Anyway, while your patch is great for shifting the ordered sequence of columns in any Rox window - the changes aren't persistent between Rox windows, and are not persistent on reboots. Any hope for tweaking your patch just a bit further for permanence?

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

Well, first I want to make it clear that I didn't write the movable columns patch. I cherry picked a commit by JakeSFR who gave the credit to forum users Otter & Rocket.
https://github.com/woodenshoe-wi/rox-filer/commit/4befe7632dfb2b37c2e8dcb50198d620f7735bc4

The copy and paste functionality was actually something I saw in a GitHub fork of rox-filer by dtomas https://github.com/dtomas/rox-filer
It did not look like it had been merged into the jun7 fork, but it would solve a complaint that rox-filer lacks proper copy and paste support. When I added "cut to clipboard" support I accidentally added a segfault, which I fixed when I found it, and I also made changes to the original implementation of "copy and paste" to fix problems I found with it.

My original motivation for making these changes was to get the "overwrite if newer" check box working properly because there were two camps of ROX users, those including myself who were happy with the old behavior of being prompted about every overwrite, and those that found the prompts irritating and preferred to use a newer version of ROX that didn't prompt when overwriting regardless of whether the overwriting file was newer or older than the file that was being overwritten.

When I was working on this I also noticed that the function that handled moving files and directories had diverged from the function that copies files and directories so I rewrote the "move" function to more closely match the "copy" function and now it should be possible to "merge" directories when moving them just like when copying them.

Because of all these changes and the potential for bugs and segfaults I would like people to test this version before it would be made a default version in woof builds, but I am not sure how to go about getting it tested. There are no "testing" version package lists, once it would be uploaded to ibiblio it could end up being the default version which would be bad if it had any serious bugs.

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

New version again. These are the standalone versions that will not overwrite any settings, but should not be used for woof builds.

Edit: These were buggy, newer versions posted later.

This version makes NO changes to rox column management, but instead adds the feature that when a directory is open in a filer window and the directory no longer exists because it is unmounted or deleted the filer window will be automatically closed.

Pets that are suitable for woof builds are also available,
Edit: These were buggy, newer versions posted later.
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds. Also @peebee please DON'T upload to ibiblio unless or until you are confident that they work properly. I am posting them for more thorough testing.

It should also be possible to use my gitlab repo for test woof builds by

All 3 steps are needed.

Starting with version 6, the name that has to be added to DISTRO_PKGS_SPECS is no longer "rox-filer-woodenshoe", just the standard "rox-filer".

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

Version 2 was buggy, this new version can also configure which columns are visible in "List View".

Edit: Newer versions posted later.

Pets that are suitable for woof builds are also available,
Edit: Newer versions posted later.
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds. Also @peebee please DON'T upload to ibiblio unless or until you are confident that they work properly. I am posting them for more thorough testing.

davids45 · Joined: 26 Nov 2006 Posts: 1181 Location: Chatswood, NSW

G'day woodenshoe-wi,

In response to your post on the Rox poll thread Smile

, I had just tried your latest .pet for your Rox in a BionicPup1805-2+Sc64bit-kernel Frugal.

The new Rox column adjustability is better - I deleted the never-been-used 'Permissions', 'Owner' and 'Group' columns (screenshot).

This Pup was already fully apped with my apps-links sfs and the pinboard icon labels edited by me, these apps having been dragged as .desktop files from /usr/share/applications/ so I remove '.desktop' and sometimes shorten what's left to fit under the icon.

1) with the new Rox, no .desktop to worry about but some application icon labels became too long and overlapped text of adjacent icons (screenshot)

2) when I tried to edit the too-long labels, I couldn't with your Rox. This may be something due to these being links to my data partition, not a 'normal' file on my frugals partition?

Can I edit something to shorten the over-long labels before they're being loaded onto the pinboard?

I found nothing else an issue with some quick tests with your Rox but have reverted to my previous savefile with its older Rox version and icon-text-editable pinboard (screenshot).

Happy to try anything else when I can.

Thanks for your work with Rox,

David S.

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

Thank you for testing davids45, I don't normally link .desktop files to my pinboard so I wouldn't have found the bug by myself.

Looking into the problem it seems that when the feature to use the name from .desktop files was added it would always override any user edits.

Here are new pets with a fix applied:
Edit: Newer versions posted later.

Pets that are suitable for woof builds are also available,
32 bit version https://gitlab.com/woodenshoe-wi/petbuilds-out/tree/master/puppylinux/pet_packages-common32
64 bit version https://gitlab.com/woodenshoe-wi/petbuilds-out/tree/master/puppylinux/pet_packages-common64
But as before, be warned that they will reset your desktop background, overwrite your pin-board and possibly other unwanted changes... They are meant for woof builds.

recobayu · Joined: 15 Sep 2010 Posts: 326 Location: indonesia

Thank you, woodenshoe-wi.
I download your rox standalone and common. I install it on bionicpup. I got error on common's rox. I can not click on toolbar and i can not right click. But it does not happen with rox standalone in my bionicpup.
I am very happy because now i can make new directory by clicking on '+' toolbar. Also i can hide the unused column in list view.

I also thank you. Because I can copy-paste multiple file with yor rox-filer.

I still have problem when i will select multiple file by mouse (block by click and drag) in list view mode. I must choose the right coordinate (usually a line between two file) so i can block it. Could it be more easier as icon view does?

But I say thank you again for your hard work.
Smile

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

Smithy · Joined: 12 Dec 2011 Posts: 984

Hello woodenshoe, is there somewhere in your code to:

1. Remove the Copy dialogue completely (the shift+Ctrl+C one)
2. Rename Copy to Clipboard just to Copy.
3. Rename Cut to Clipboard just to Cut.
4 Make the delete dialogue operate with the Delete button on keyboard
as opposed to the laborious Shift+Ctrl+X
5. Rename Paste to Clipboard to just Paste.

6. And finally have them grouped in the same area as the rename and delete section.

Been testing those items and they are rock solid, but just would like to remove the duplication (Copy) and move them right next to each other to slim down the right click a bit.

step · Joined: 04 May 2012 Posts: 1168

Hi Smithy, two things you asked about, renaming a menu item and changing its hot key, can be done also without changing the source code. Of course, changing the source code is another way.
I tested these methods on Fatdog64 ROX-Filer, I don't know if the version in this thread behaves the same way, but my guess is that it does.

To change a hotkey select (don't click) the menu option that you want to change and press the key you want for it. For instance, the picture you posted is exactly at the right spot for changing Ctrl+Shift+C to F5. Just press Del once (to free Ctrl+Shift+C) and press F5 (to assign F5). You should see the menu entry change to "Copy... (F5)".

Changing the text of menu entries is more complicated, but achievable. The gist of it is to add a custom translation file inside the ROX-Filer application folder, for your case, exactly adding file /usr/local/apps/ROX-Filer/Messages/en/LC_MESSAGES/ROX-Filer.mo. How to create ROX-Filer.mo. That's the more complicated part, if you have no previous experience with translating Puppy Linux. PM me if you're interested. No offense taken if you aren't.

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

step · Joined: 04 May 2012 Posts: 1168

Smithy · Joined: 12 Dec 2011 Posts: 984

Hi step, woodenshoe, first of all, reading through the information in both of your posts, I was just wondering if rox filer had a script or suchlike, where I could chop for example the copy line out at line number xx and shift the text a bit. Clearly not, looking inside.

I only compile the odd driver in a blue moon and those lc translations and .mo files down in the bowels of puppy I just have a quick look to make sure that apps have a bit of internationalisation if I'm making one.

I only wanted to do that for a user perspective copy, (even though this version is in final music2go sfs that I put together).

I realise that probably loads of puppy devs and users rely on the Shift+Ctrl+C and probably other key commands, so I didn't mean for you to change your official version Smile

If the delete key eventually becomes delete that will be great, the rest of my bullet points are really just cosmetic and a lot of the time I am ctrl c, ctrl x and ctrl v and of course...delete.

Actually duplicate could be a good idea woodenshoe, sort of makes sense.

I would say this rox filer makes things about 50% faster than the old drag and dropper that we have had to live with for years.. and got rid of the glipper thing on the taskbar.

woodenshoe-wi · Joined: 28 Jul 2017 Posts: 104 Location: Wisconsin

@step I knew where the key binding was set but I couldn't figure out how to tell GTK to use the 'Delete' key. I had tried "<Del>" and "<Delete>" but it wouldn't recognize it. Somehow your post inspired me to try "Delete" and success!. I have the 'Delete' key assigned to the 'Delete' dialogue!