Init Typo

Please post any bugs you have found
Post Reply
Message
Author
User avatar
corvus
Posts: 153
Joined: Fri 12 Jun 2015, 18:00
Location: In the peninsula shaped like a boot.

Init Typo

#1 Post by corvus »

Good morning, I report the following typo in the init file in initrd.gz, found in Bionicpup64 and LxPupSc64, maybe it exists in other versions of Puppy:

Bionicpup64 line 82 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

LxPupSc64 line 81 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

I think it should be [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="ydrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

May be of interest to someone.

Best regards
[b]We are waves of the same sea, leaves of the same tree, flowers of the same garden.[/b]

s243a
Posts: 2580
Joined: Tue 02 Sep 2014, 04:48
Contact:

Re: Init Typo

#2 Post by s243a »

corvus wrote:Good morning, I report the following typo in the init file in initrd.gz, found in Bionicpup64 and LxPupSc64, maybe it exists in other versions of Puppy:

Bionicpup64 line 82 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

LxPupSc64 line 81 -> [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="adrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

I think it should be [ ! "$DISTRO_YDRVSFS" ] && DISTRO_YDRVSFS="ydrv_${DISTRO_FILE_PREFIX}_${DISTRO_VERSION}.sfs"

May be of interest to someone.

Best regards
Please report the issue here:

https://github.com/puppylinux-woof-CE/woof-CE/issues

or do a pull/merge request. THe file that needs fixing is here:
https://github.com/puppylinux-woof-CE/w ... nitrd/init

The branch that people work on is the "testing" branch. If you don't get around to reporting this issue I'm sure someone else will (e.g. me) but I would like to encourage people to contribute on github :)
Find me on [url=https://www.minds.com/ns_tidder]minds[/url] and on [url=https://www.pearltrees.com/s243a/puppy-linux/id12399810]pearltrees[/url].

User avatar
corvus
Posts: 153
Joined: Fri 12 Jun 2015, 18:00
Location: In the peninsula shaped like a boot.

#3 Post by corvus »

s243a wrote:Please report the issue here:

https://github.com/puppylinux-woof-CE/woof-CE/issues

or do a pull/merge request. THe file that needs fixing is here:
https://github.com/puppylinux-woof-CE/w ... nitrd/init
Honestly registering on GitHub just to report a single typo seems a bit exaggerated.
s243a wrote:If you don't get around to reporting this issue I'm sure someone else will (e.g. me)
It seems to me the best solution. Thanks for your help s243a.

Have a nice day
[b]We are waves of the same sea, leaves of the same tree, flowers of the same garden.[/b]

User avatar
rockedge
Posts: 1864
Joined: Wed 11 Apr 2012, 13:32
Location: Connecticut, United States
Contact:

#4 Post by rockedge »

Hello corvus and s243a,

I reported it on github woof-CE site in the Issues section

Nice catch corvus! I just was wondering why a ydrv.sfs wasn't loading at boot.

Thanks....hope all is well in Italy

s243a
Posts: 2580
Joined: Tue 02 Sep 2014, 04:48
Contact:

#5 Post by s243a »

rockedge wrote:Hello corvus and s243a,

I reported it on github woof-CE site in the Issues section

Nice catch corvus! I just was wondering why a ydrv.sfs wasn't loading at boot.

Thanks....hope all is well in Italy
Thankyou, rockedge and corvus. :)
Find me on [url=https://www.minds.com/ns_tidder]minds[/url] and on [url=https://www.pearltrees.com/s243a/puppy-linux/id12399810]pearltrees[/url].

User avatar
corvus
Posts: 153
Joined: Fri 12 Jun 2015, 18:00
Location: In the peninsula shaped like a boot.

#6 Post by corvus »

rockedge wrote:Thanks....hope all is well in Italy
Thanks rockedge for being interested. Here we live in the moment.

Best regards
[b]We are waves of the same sea, leaves of the same tree, flowers of the same garden.[/b]

s243a
Posts: 2580
Joined: Tue 02 Sep 2014, 04:48
Contact:

#7 Post by s243a »

micko fixed this (5hours ago) per the report in the original post. See:

https://github.com/puppylinux-woof-CE/w ... 758ef50734

thankyou for reminding as about this typo :)
Find me on [url=https://www.minds.com/ns_tidder]minds[/url] and on [url=https://www.pearltrees.com/s243a/puppy-linux/id12399810]pearltrees[/url].

Post Reply