Pcdripper-3.9.4

Audio editors, music players, video players, burning software, etc.
Message
Author
plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#31 Post by plinej »

I didn't see your last post but I'll work more on some of your suggestions. I did find and fix a couple of bugs, I also worked on your previous requests.

3.6 is up now.

User avatar
ravensrest
Posts: 365
Joined: Fri 22 Feb 2008, 16:43
Location: Grants Pass, Oregon

#32 Post by ravensrest »

plinej wrote:I didn't see your last post but I'll work more on some of your suggestions. I did find and fix a couple of bugs, I also worked on your previous requests.

3.6 is up now.
So far, so good with 3.6. I like it a bunch. Hope you do accomodate some of my other requests. So far I have ripped over 70 disks with your scripts!

Regards,
BS

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#33 Post by plinej »

Great, glad it's getting used. I've ripped quite a bit with it too. I will try and work on it some more next week.

disciple
Posts: 6984
Joined: Sun 21 May 2006, 01:46
Location: Auckland, New Zealand

#34 Post by disciple »

Flash is right, and pawdioconverter doesn't work with spaces in paths (unless you've fixed it lately).
It would be nice if that was fixed - I looked at it back when I fixed it in pfind and the trash roxapp, but pawdioconverter was just too daunting for me :)
Do you know a good gtkdialog program? Please post a link here

Classic Puppy quotes

ROOT FOREVER
GTK2 FOREVER

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#35 Post by plinej »

I haven't used it in a while but I'll add it to the list of things to work on. I don't know how much time I want to put into it though. I'd almost rather start over from scratch on that one.

User avatar
HairyWill
Posts: 2928
Joined: Fri 26 May 2006, 23:29
Location: Southampton, UK

#36 Post by HairyWill »

Jason
not sure if you are aware of this one as I don't do a lot of ripping
I have some CDs where the CDDB lookup returns a genre that isn't in lames list of genres:
http://lame.cvs.sourceforge.net/*checko ... l/id3.html
This causes lame to fail. It would be nice if you could either drop the genre if it was not acceptable to lame. Even better would be if I got to choose a genre from the allowed list.
Will
contribute: [url=http://www.puppylinux.org]community website[/url], [url=http://tinyurl.com/6c3nm6]screenshots[/url], [url=http://tinyurl.com/6j2gbz]puplets[/url], [url=http://tinyurl.com/57gykn]wiki[/url], [url=http://tinyurl.com/5dgr83]rss[/url]

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#37 Post by plinej »

Alright, I thought I had some code in there that should reject an unknown genre. I'll look into it when I get a chance.

User avatar
HairyWill
Posts: 2928
Joined: Fri 26 May 2006, 23:29
Location: Southampton, UK

#38 Post by HairyWill »

there is some code in there but I don't think it works. It is doing comparisons between the number of characters in the genre.

I think that the following line might work to replace about 15 lines of code

Code: Select all

lame --genre-list | grep "$GENRE" >/dev/null || GENRE=Other
Will
contribute: [url=http://www.puppylinux.org]community website[/url], [url=http://tinyurl.com/6c3nm6]screenshots[/url], [url=http://tinyurl.com/6j2gbz]puplets[/url], [url=http://tinyurl.com/57gykn]wiki[/url], [url=http://tinyurl.com/5dgr83]rss[/url]

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#39 Post by plinej »

3.7 is up. It should fix the problem described by HairyWill.

User avatar
melvix
Posts: 96
Joined: Sat 14 Jul 2007, 18:48
Location: Vilnius, Lithuania
Contact:

#40 Post by melvix »

plinej, thanks for your works!
What you think about multilingual support? As in Pburn, for example.
We are planning to translate in Russian.
Best regards.
[url=http://www.puppyrus.org/]Free software for free people![/url]

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#41 Post by plinej »

If I get some spare time I'll look at the Pburn code and see how difficult it will be.

User avatar
Flash
Official Dog Handler
Posts: 13071
Joined: Wed 04 May 2005, 16:04
Location: Arizona USA

#42 Post by Flash »

Will someone please point me in the right direction to figure out how to make my Pcdripper settings persist? I rip audio books to mp3 so I can listen to them on my mp3 player, and I have to reenter almost every option for each CD. Not only does that slow me down (audio books typically have 6 CDs, and some have more than 20) but sometimes I even make mistakes. :oops:

User avatar
Flash
Official Dog Handler
Posts: 13071
Joined: Wed 04 May 2005, 16:04
Location: Arizona USA

#43 Post by Flash »

I tinkered around with /usr/sbin/pcdripper. I'm posting what I changed to have a record of what I did. If anyone else wants to take a shot at making Pcdripper's GUI more like Precord's, with all the settings in one window and so it remembers the settings, please feel free. :)

I commented out lines 2120 through 2140, and line 2146:

Code: Select all

(line 2119)##Ask to rip another disc
##export MAIN_DIALOG="
##<vbox>
## <text wrap=\"true\" width-chars=\"40\">
##    <label>Would you like to rip another disc?</label>
##  </text>
##  <hbox>
##    <button>
##       <input file icon=\"gtk-ok\"></input>
##      <label>OK</label>
##      <action type=\"exit\">Exit-RIP</action>
##    </button>
##    	<button>
##	<input file stock=\"gtk-quit\"></input>
##        <label>QUIT</label>
##        <action type=\"exit\">EXIT_NOW</action>
##      </button>
##  </hbox>
## </vbox>
##"
##RIPAGAIN=`$GTKDIALOG --program=MAIN_DIALOG --center`
##(line 2140)if [ "`echo $RIPAGAIN | grep Exit-RIP`" != "" ]; then
pcdripper &
else
exit 0
fi

##(line 2146)exit 0 ##all done
What this change did was stop Pcdripper from asking if I want to rip another CD. Now it just goes back to the starting GUI window when it finishes ripping a CD. Usually the settings aren't retained, though sometimes a few of them are. It's a start.

User avatar
Flash
Official Dog Handler
Posts: 13071
Joined: Wed 04 May 2005, 16:04
Location: Arizona USA

#44 Post by Flash »

OK, that didn't do much good. :(

I just discovered this thread, "GtkDialog - tips" in the HOWTO section of the forum. :oops:
This post appears to describe how to change default settings for radio buttons.

If I live long enough maybe I'll figure out how to fix Pcdripper the way I want it. :lol:

User avatar
thunor
Posts: 350
Joined: Thu 14 Oct 2010, 15:24
Location: Minas Tirith, in the Pelennor Fields fighting the Easterlings
Contact:

#45 Post by thunor »

Since this is the official thread for Pcdripper I have a couple of fixes for 3.7, the version that's shipped with Lucid 5.20. It doesn't look as though this is currently being maintained but I find it useful and it's a shame to leave it broken.

The first issue was with audio formats being empty, and the second was with music categories being dumped to the terminal rather than to a file (lame --genre-list goes to stderr not stdout).

Change:

/usr/sbin/pcdripper:236:cat /tmp/$WHOAMI-pcdripper-formats | sort -u > /tmp/$WHOAMI-pcdripper-formats

to:

/usr/sbin/pcdripper:236:cat /tmp/$WHOAMI-pcdripper-formats | sort -u -o /tmp/$WHOAMI-pcdripper-formats

Change:

/usr/sbin/pcdripper:1885:lame --genre-list | grep -i "$GENRE" | sed 's/[0-9]//g' | tr -s ' ' | sed 's/^ //g' > /tmp/$WHOAMI-pcdripper-genrelist

to

/usr/sbin/pcdripper:1885:lame --genre-list 2>&1 | grep -i "$GENRE" | sed 's/[0-9]//g' | tr -s ' ' | sed 's/^ //g' > /tmp/$WHOAMI-pcdripper-genrelist

I also had a cddb_query error about libcdio.so.7 not found (libcdio.so.10 is installed) so I compiled libcddb-1.3.2 which includes cddb_query and it now works.

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#46 Post by plinej »

updated to 3.8 and added libcddb-1.3.2-i686.pet which is needed in lucid 525 due to cddb_query being broken.

User avatar
sc0ttman
Posts: 2812
Joined: Wed 16 Sep 2009, 05:44
Location: UK

#47 Post by sc0ttman »

melvix wrote:plinej, thanks for your works!
What you think about multilingual support? As in Pburn, for example.
We are planning to translate in Russian.
Best regards.
I have an i18n'd version, updated to 3.8 .. I will upload it soon. Here is the english .mo ..
Just translate, post here, and I will package up the .pet
#English

L1="You need to install a suitable terminal, like rxvt"
L2="OK"
L3="You need to install either cdparanoia, cdda2wav, or icedax to rip a cd"
L4="Close"
L5="Rip"
L6="rip program cd scan"
L7="Help"
L8="Web link"
L9="Quit"
L10="Click for options"
L11="Select audio format"
L12="Select your CD drive"
L13="Select your save to directory"
L14="Select a Directory"
L15="Ripping options"
L16="use"
L17="manual id3 tags"
L18="no id3 tags"
L19="cddb_query tags"
L20="disable"
L21="disable extra paranoia"
L22="output to a single track"
L23="exit on a bad read"
L24="eject when done"
L25="rip the full cd"
L26="play a sound when finished"
L27="Enter preceding name for tracks"
L28="Enter range, single file, or various multiple files"
L29="See the help file for more info"
L30="T=track N=name A=artist Y=year L=album G=genre"
L31="Enter track name format"
L32="Selected file format"
L33="cddb_query not found in your PATH"
L34="cddetect information"
L35="cd-info information"
L36="CD information"
L37="cddb_query is checking the online database"
L38="The selected file format doesn't accept tagging but it will use the cddb_query results in naming the tracks"
L39="Check here if this information is correct?"
L40="Select your desired compression ratio"
L41="Select your desired bitrate"
L42="highest quality"
L43="Constant or Varying bit rates?"
L44="Constant Bit Rate"
L45="Varying Bit Rate"
L46="Mono or Stereo mp3s?"
L47="Stereo"
L48="Mono"
L49="lowest quality"
L50="Select your desired Quality"
L51="Program can not detect any audio tracks on the cd"
L52="Your last track needs to be greater than the first track in the requested range, or the range you selected is greater than the total number of tracks"
L53="Requested track $TRACKS is more than the total number - $TOTALTRACKS - on the disc"
L54="The selected file format doesn't accept tagging but it will use your entries in naming the tracks"
L55="Enter track title"
L56="Enter track Year"
L57="Enter album name"
L58="ALBUM"
L59="Enter artist name"
L60="Enter track genre"
L61="Enter a comment"
L62="Enter track composer"
L63="Enter track lyricist"
L64="NEXT"
L65="pcdripper script to be executed - you can edit if necessary"
L66="INFO"
L67="Would you like to rip another disc?"
[b][url=https://bit.ly/2KjtxoD]Pkg[/url], [url=https://bit.ly/2U6dzxV]mdsh[/url], [url=https://bit.ly/2G49OE8]Woofy[/url], [url=http://goo.gl/bzBU1]Akita[/url], [url=http://goo.gl/SO5ug]VLC-GTK[/url], [url=https://tiny.cc/c2hnfz]Search[/url][/b]

Country Bumkin
Posts: 29
Joined: Sun 26 Jul 2009, 03:19
Location: Australia

#48 Post by Country Bumkin »

I am trying to rip a privately made CD so there is no Internet data available so I used 'manual ID3 tags'. The correct number of track entry fields were requested but only the first track was ripped, then I was prompted for a new disk. I tried a manual track range with the same result.

Command Window Showed

cdparanoia 1-1 -d /dev/sr0 - | lame - --ty "0000" --tn "1" --ta "AR1" --tl "AB1" --tt "TK1" --tg "Other" --tc "" -"V" "3" -"mj" "AB1-01-TK1".mp3
cdparanoia 2-2 -d /dev/sr0 - | lame - --ty "0000" --tn "2" --ta "AR1" --tl "AB1" --tt "TK2" --tg "Other
Other" --tc "" -"V" "3" -"mj" "AB1-02-TK2".mp3
cdparanoia 3-3 -d /dev/sr0 - | lame - --ty "0000" --tn "3" --ta "AR1" --tl "AB1" --tt "TK3" --tg "Other
Other
Other" --tc "" -"V" "3" -"mj" "AB1-03-TK3".mp3
cdparanoia 4-4 -d /dev/sr0 - | lame - --ty "0000" --tn "4" --ta "AR1" --tl "AB1" --tt "TK4" --tg "Other
Other
Other
Other" --tc "" -"V" "3" -"mj" "AB1-04-TK4".mp3
exit 0


(Pcdripper 3.8, rip to mp3, VBR, stereo, Q=3, Puppy official 4.3.1, Toshiba A200 laptop)

Any ideas ?

Regards C Bumkin

plinej
Posts: 1742
Joined: Mon 14 Aug 2006, 02:21

#49 Post by plinej »

I couldn't replicate your trouble but the output showed a definite bug so I fixed that and posted 3.8.1. Install the new version and try again. If it doesn't work post the same screen where it shows the commands that are to be executed.

Country Bumkin
Posts: 29
Joined: Sun 26 Jul 2009, 03:19
Location: Australia

#50 Post by Country Bumkin »

plinej wrote:I couldn't replicate your trouble but the output showed a definite bug so I fixed that and posted 3.8.1. Install the new version and try again. If it doesn't work post the same screen where it shows the commands that are to be executed.
The command window now looks like a logical command set, rip is processing normally. Thanks for the prompt response.

Regards C Bumkin

Post Reply