Page 92 of 117

Posted: Mon 18 Aug 2014, 20:06
by zigbert
Version 4.3,9
See main post

Changelog
Bugfix: Rip audio-CD that contains quotes in meta-info. (thanks to charlie6)

Posted: Thu 04 Sep 2014, 07:42
by zigbert
Version 4.4.0
See main post


Changelog
- Optional installation of new music files to DB (to nooby - rip).
. . . .- show quest in main gui if user want to install music from source.
. . . .- remove auto-loading of fresh music into DB.
. . . .- still updates db on first run.
. . . .- still adds played tracks to db.
- Improved packaging.
. . . .- Alternative non-puppy packages for frontends/plugins/themes.
. . . .- Mirror all packages at 01micko.com (thanks to 01mick0)
. . . .- Setup alternative FTP-server (01micko.com)
. . . . . . . .- Quick install of radio index.
. . . . . . . .- Quick install of jamendo index.
. . . . . . . .- Show FAQ.
- Update radio/webmusic indexes.
- Bugfix: installing a more recent radio/webmusic index doesn't overwrite the existing.
- Bugfix: New adress to jamendo db-dump file. pMusic fails to 'manually' build index file.

Posted: Sun 07 Sep 2014, 06:59
by zigbert
Version 4.4.1
See main post

Changelog
- Bugfix: Trackinfo: Albumlist: Doubleclick to add track to playqueue.
- Bugfix: Add searched albumart to playqueue via right-click menu when Capitals differs from jpg to pmu.
- Bugfix: Trackinfo does quick indexing even if user choose to skip this in main gui.

Posted: Thu 09 Oct 2014, 18:56
by zigbert
Version 4.4.2
See main post

Changelog
- Bugfix: Delete track from the 'Database mismatch' dialog should not add the file to playqueue.
- Bugfix: Press play-button after played playqueue corrupts queue.
- Bugfix: Pless play-button after first stopped playing from menu.

Posted: Wed 29 Oct 2014, 14:18
by zigbert
Version 4.4.3
See main post

Changelog
- Bugfix: Moving slider could give playback error and corrupt db.
- Bugfix: Show generic albumart if albumtag is missing and no connection to internet.

Posted: Mon 03 Nov 2014, 08:26
by greengeek
Hi zigbert, I have a really strange problem that I don't understand. I don't really want to mention it because the problem could be caused by the fact that I am using a strangely modified version of Slacko 5.6. It is my own derivative that has unusual zdrive layering - so I may have done something odd that is causing this behaviour.

Anyway - the strange behaviour may possibly be related somehow to pmusic, as I seem to get desktop icon corruption sometime AFTER i use pmusic, so I thought I would mention it here in case anyone had seen something similar.

Sometimes I lose my desktop icon "matches" and end up with the generic black and white "gear" and "script" icons instead of the normal multicolor icons. (Except for the "connect" icon, which remains as normal). The icons do not return to normal after a restart of X.

I don't know if it is related, but occasionally I also see the following message:

Code: Select all

"Error in '/root/.config/rox.sourceforge.net/ROXFiler/globicons' file at line 2:
"Invalid line in globicons: no icon specified"
This may be due to upgrading from a previous version of ROX-Filer. Open the Options window and try changing something then changing it back (causing the file to be resaved). Further errors will be ignored."
When I look at root/.config/rox.sourceforge.net/ROXFiler/globicons I see the following:

Code: Select all

<?xml version="1.0"?>
<special-files>
  <rule match="<rule">
    <icon>match="/usr/local/pmusic/pmusic"></icon>
  </rule>
</special-files>
Is there an icon specification missing here?

This seems to occur after I have played back some audio via pmusic. Could the icon loss and pmusic error message be related? (My pmusic is 4.1.1)

nooby reported something similar here
(The pic he showed of the icon condition is the same sort of thing I see too).

Any ideas gratefully received :-)

Posted: Mon 03 Nov 2014, 16:53
by zigbert
greengeek
Hmm, looks like bash somehow works different on your system....
At first run, pMusic adds itself to globicons. The code is found in /usr/local/pmusic/pmusic. Line 144 in the latest version 4.4.3.

Code: Select all

	#give pmusic executable an icon in Rox
	if [ ! "`grep -F 'pmusic.svg' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons`" ]; then
		grep -vF '</special-files>' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons > $WORKDIR/tmp
		cat >> $WORKDIR/tmp << EOF  
  <rule match="/usr/local/pmusic/pmusic">
   <icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</icon>
  </rule>
</special-files>
EOF
		mv $WORKDIR/tmp ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons
	fi
Can it be the use of EOF? It could eg. be done this way instead:

Code: Select all

	#give pmusic executable an icon in Rox
	if [ ! "`grep -F 'pmusic.svg' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons`" ]; then
		grep -vF '</special-files>' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons > $WORKDIR/tmp
		echo '<rule match="/usr/local/pmusic/pmusic">
   <icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</icon>
  </rule>
</special-files>' >> $WORKDIR/tmp
		mv $WORKDIR/tmp ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons
	fi
I would like to remind you that your running version of pMusic was released 14 months ago.
This how my globicons file look like

Code: Select all

<?xml version="1.0"?>
<special-files>
  <rule match="/usr/bin/gnumeric">
    <icon>/usr/local/lib/X11/pixmaps/spread48.png</icon>
  </rule>
  <rule match="/usr/sbin/savesession-dvd">
    <icon>/usr/local/lib/X11/pixmaps/save48.png</icon>
  </rule>
  <rule match="/root/.pup_event/drive_sda1">
    <icon>/usr/local/lib/X11/pixmaps/drive_mntd_boot48.png</icon>
  </rule>
  <rule match="/usr/local/pmusic/pmusic">
    <icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</icon>
  </rule>
  <rule match="/root/.pup_event/drive_sdc1">
    <icon>/usr/local/lib/X11/pixmaps/usbdrv48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultcontact">
    <icon>/usr/local/lib/X11/pixmaps/contact48.png</icon>
  </rule>
  <rule match="/usr/sbin/dotpup">
    <icon>/usr/local/lib/X11/pixmaps/pet48.png</icon>
  </rule>
  <rule match="/usr/sbin/pmount">
    <icon>/usr/local/lib/X11/pixmaps/drive48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultmediaplayer">
    <icon>/usr/local/lib/X11/pixmaps/multimedia48.png</icon>
  </rule>
  <rule match="/usr/sbin/wizardwizard">
    <icon>/usr/local/lib/X11/pixmaps/configuration48.png</icon>
  </rule>
  <rule match="/usr/local/bin/rox">
    <icon>/usr/local/lib/X11/pixmaps/home48.png</icon>
  </rule>
  <rule match="/usr/sbin/save2flash">
    <icon>/usr/local/lib/X11/pixmaps/save48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultpaint">
    <icon>/usr/local/lib/X11/pixmaps/paint48.png</icon>
  </rule>
  <rule match="/usr/sbin/puppyhelp">
    <icon>/usr/local/lib/X11/pixmaps/help48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultdraw">
    <icon>/usr/local/lib/X11/pixmaps/draw48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultwordprocessor">
    <icon>/usr/local/lib/X11/pixmaps/word48.png</icon>
  </rule>
  <rule match="/root/.pup_event/drive_sdb1">
    <icon>/usr/local/lib/X11/pixmaps/drive_mntd48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaulttexteditor">
    <icon>/usr/local/lib/X11/pixmaps/edit48.png</icon>
  </rule>
  <rule match="/usr/sbin/petget">
    <icon>/usr/local/lib/X11/pixmaps/pet48.png</icon>
  </rule>
  <rule match="/usr/bin/rxvt">
    <icon>/usr/local/lib/X11/pixmaps/console48.png</icon>
  </rule>
  <rule match="/root/.pup_event/drive_sdd1">
    <icon>/usr/local/lib/X11/pixmaps/usbdrv48.png</icon>
  </rule>
  <rule match="/usr/bin/urxvt">
    <icon>/usr/local/lib/X11/pixmaps/console48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultcalendar">
    <icon>/usr/local/lib/X11/pixmaps/date48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaulthtmleditor">
    <icon>/usr/local/lib/X11/pixmaps/webedit48.png</icon>
  </rule>
  <rule match="/usr/local/bin/mozmail">
    <icon>/usr/local/lib/X11/pixmaps/email48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultbrowser">
    <icon>/usr/local/lib/X11/pixmaps/www48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultspreadsheet">
    <icon>/usr/local/lib/X11/pixmaps/spread48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultemail">
    <icon>/usr/local/lib/X11/pixmaps/email48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultchat">
    <icon>/usr/local/lib/X11/pixmaps/chat48.png</icon>
  </rule>
  <rule match="/root/.pup_event/drive_sr0">
    <icon>/usr/local/lib/X11/pixmaps/optical48.png</icon>
  </rule>
  <rule match="/usr/local/bin/defaultconnect">
    <icon>/usr/local/lib/X11/pixmaps/connect48.png</icon>
  </rule>
</special-files>

Posted: Sat 15 Nov 2014, 08:33
by zigbert
deleted - more fixing required
______________________________________________________________


Version 4.4.4
See main post

Changelog
- Do not update db if nothing changed. (Resourse hunger):
. . . .- detection of albumart-url.
. . . .- building album list.
- Smartadd
. . . .- Smartadd can be slow when filter by rating in a huge db. Give more info in splash.
. . . .- Run Smartadd as background process.
- Reduce cpu-load when reading trackinfo for new playing track.
- Avoid grep locked db (flock) if string is written back to db. - Will corrupt db.
- Bugfix: Rox globicons file corrupted by pMusic. (thanks to greengeek)
- Bugfix: Download album art from albumart.org

Posted: Sat 15 Nov 2014, 16:49
by xanad
Ciao zigbert
4.4.3 mo it

Posted: Sat 15 Nov 2014, 20:32
by greengeek
zigbert wrote:Hmm, looks like bash somehow works different on your system....
At first run, pMusic adds itself to globicons. The code is found in /usr/local/pmusic/pmusic. Line 144 in the latest version 4.4.3...Can it be the use of EOF? It could eg. be done this way instead:

Code: Select all

	#give pmusic executable an icon in Rox
	if [ ! "`grep -F 'pmusic.svg' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons`" ]; then
		grep -vF '</special-files>' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons > $WORKDIR/tmp
		echo '<rule match="/usr/local/pmusic/pmusic">
   <icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</icon>
  </rule>
</special-files>' >> $WORKDIR/tmp
		mv $WORKDIR/tmp ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons
	fi
Hi zigbert, thanks for the trial code. Unfortunately it did not change the problem. I also tried Pmusic 4.4.3 and it gave the same trouble. Obviously it must be something odd with my system but I have not figured it out yet.

So just to summarise in case someone else has a similar problem:
- When I first start pmusic it creates the file /root/.config/.rox.sourceforge.net/ROX-Filer/globicons (which did not exist previously)
- This file seems to have incorrect syntax for the rox icon that it is intended to add.
- This brings up an error message and also has the effect that when I hover the mouse over (almost) any desktop icon the normal icon image disappears and gets replaced by the 'generic script' icon

In case it is a bash issue, my version is as follows:

Code: Select all

# bash -version
GNU bash, version 4.1.14(2)-release (i686-pc-linux-gnu)
If I restart x the problem continues. However if i remove the bad globicons file and restart x again the problem disappears.

I can also get around the problem in two other ways:
1) Comment out lines 130-140 in my pmusic (ver 4.1.1) which specify the creation of the globicons file. This has to be done before I run pmusic the first time.
2) I can use geany to open /root/.pmusic.pmusicrc and change line 36:

Code: Select all

export FIRST_RUN=true
to "false". The globicons file creation only occurs on pmusics first run.

Zigbert - the globicons file that you have shown - is that /root/.config/.rox.sourceforge.net/ROX-Filer/globicons.xml or is it /root/Choices/ROX-Filer/globicons.xml?

I will keep trying to pin down why this problem is happening and will post back if I discover the reason.

Posted: Sat 15 Nov 2014, 21:18
by SFR
@Zigbert: you can avoid direct modifications of globicons file by using Rox's SOAP RPC, check this out:

Code: Select all

#!/bin/sh

touch /root/SomeTestFile

rox --RPC << EOF
<?xml version="1.0"?>
<env:Envelope xmlns:env="http://www.w3.org/2001/12/soap-envelope">
 <env:Body xmlns="http://rox.sourceforge.net/SOAP/ROX-Filer">
  <SetIcon>
   <Path>/root/SomeTestFile</Path>
   <Icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</Icon>
  </SetIcon>
 </env:Body>
</env:Envelope>
EOF
HTH 8)

Greetings!

Posted: Sat 15 Nov 2014, 22:09
by greengeek
Hi zigbert - what happens if I do not have a pre-existing /root/.config/rox.sourceforge.net/ROX-Filer/globicons file? In that case where does the following code find the rest of the contents for the new globicons file?

Code: Select all

	#give pmusic executable an icon in Rox
	if [ ! "`grep -F 'pmusic.svg' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons`" ]; then
		grep -vF '</special-files>' ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons > $WORKDIR/tmp
		cat >> $WORKDIR/tmp << EOF  
  <rule match="/usr/local/pmusic/pmusic">
   <icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</icon>
  </rule>
</special-files>
EOF
		mv $WORKDIR/tmp ${HOME}/.config/rox.sourceforge.net/ROX-Filer/globicons
	fi
EDIT : OK, more testing has proven that my problem is caused by the fact that my remastering does not bring across /root/.config/rox.sourceforge.net/ROX-Filer/globicons.
I only bring across /root/Choices/ROX-Filer/globicons, which seems to work fine in terms of setting up my desktop as I want it to be.

Can anyone suggest why the other globicons file is necessary? Are there likely to be other programs other than pmusic that need to access that file too?

Posted: Sun 16 Nov 2014, 14:40
by zigbert
xanad wrote:Ciao zigbert
4.4.3 mo it
Thank you!

Sigmund

Posted: Sun 16 Nov 2014, 14:53
by zigbert
SFR wrote:@Zigbert: you can avoid direct modifications of globicons file by using Rox's SOAP RPC, check this out:

Code: Select all

#!/bin/sh

touch /root/SomeTestFile

rox --RPC << EOF
<?xml version="1.0"?>
<env:Envelope xmlns:env="http://www.w3.org/2001/12/soap-envelope">
 <env:Body xmlns="http://rox.sourceforge.net/SOAP/ROX-Filer">
  <SetIcon>
   <Path>/root/SomeTestFile</Path>
   <Icon>/usr/share/icons/hicolor/scalable/apps/pmusic.svg</Icon>
  </SetIcon>
 </env:Body>
</env:Envelope>
EOF
HTH 8)

Greetings!
Added - thanks a lot :)

Posted: Sun 16 Nov 2014, 14:57
by zigbert
greengeek
SFR's solution is by far the best option. pMusic 4.4.4 will be released in short time

Posted: Tue 18 Nov 2014, 19:49
by zigbert
Version 4.4.4
See main post


Changelog
- Do not update db if nothing changed. (Resourse hunger):
--> detection of albumart-url.
--> building album list.
- Run Smartadd as background process.
- Reduce cpu-load when reading trackinfo for new playing track.
- Avoid grep locked db (flock) if string is written back to db. - Will corrupt db.
- Bugfix: Rox globicons file corrupted by pMusic. (thanks to SFR and greengeek)
- Bugfix: Download album art from albumart.org

Posted: Thu 20 Nov 2014, 05:48
by zigbert
Version 4.4.5
See main post

Changelog
- Snappier play-command
- Bugfix: Trackinfo search grabbed focus of add/play-module.
- Bugfix: info when playing CD-audio.
- Bugfix: Fetch-buttons in id3tagger does not work.

Posted: Thu 20 Nov 2014, 19:05
by greengeek
Hi zigbert- just reporting that pmusic 4.4.5 does not run on my system. At first run I saw the "initialising" splash, but it just hung with the splash on screen.

I then installed version 4.4.3 again and it worked perfectly. Tried 4.4.5 again and this time I did not see the initializing splash (obviously knows first run is not reqd) but the program gui did not open either.

(EDIT - deleted an irrelevant bit of info)

Again - my system is non-standard so others may not experience this...

Posted: Fri 21 Nov 2014, 17:27
by zigbert
greengeek
if 4.4.3 works - 4.4.5 should, so I am interested in getting this solved.

Any terminal output?

Code: Select all

pmusic --debug
Can you use the pmusic backend?

Code: Select all

pmusic -B "/dir/file"
Can you test the gui-code?

Code: Select all

gtkdialog -f /root/.pmusic/tmp/xml_pmusic

Sigmund

Posted: Fri 21 Nov 2014, 17:40
by zigbert
Good News!
ffmpeg is on its way back into Ubuntu and Debian.
pMusic favors ffmpeg over libav.