bug in snapmergepuppy

Please post any bugs you have found
Post Reply
Message
Author
User avatar
erikson
Posts: 735
Joined: Wed 27 Feb 2008, 09:22
Location: Ghent, Belgium
Contact:

bug in snapmergepuppy

#1 Post by erikson »

Puppy versions: I checked for 3.01 and for 4.00-k2.6.21.7

Background: in PUPMODE 13 (frugal install with pup_save on a flash device), pup_save updates are done from the /usr/sbin/snapmergepuppy script.

Bug description:

The script contains a test to determine whether it's called at shutdown or during the session (i.e. automatically every 30 minutes or upon user "save" command).

Code: Select all

RUNPS="`ps`"
SHUTDOWN="no"
[ "`echo "$RUNPS" | grep 'rc.shutdown'`" = "" ] && SHUTDOWN="yes"
I think this test is in error (has = instead of !=): SHUTDOWN is set to "yes" when actually the script is *not* called from /etc/rc.d/rc.shutdown.

Note that the bug is harmless most of the time, because the SHUTDOWN variable is only used to determine whether or not the user is warned and prompted to delete some files when pup_save is virtually full.
[size=84][i]If it ain't broke, don't fix it.[/i] --- erikson
hp/compaq nx9030 (1.6GHz/480MB/37.2GB), ADSL, Linksys wireless router
[url]http://www.desonville.net/[/url]
Puppy page: [url]http://www.desonville.net/en/joere.puppy.htm[/url][/size]

User avatar
BarryK
Puppy Master
Posts: 9392
Joined: Mon 09 May 2005, 09:23
Location: Perth, Western Australia
Contact:

#2 Post by BarryK »

That was fixed awhile ago. The snapmergepuppy in the 4.1 alphas and betas has the fix.
[url]https://bkhome.org/news/[/url]

Post Reply