Puppy Linux Discussion Forum Forum Index Puppy Linux Discussion Forum
Puppy HOME page : puppylinux.com
"THE" alternative forum : puppylinux.info
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

The time now is Fri 17 Nov 2017, 15:53
All times are UTC - 4
 Forum index » Taking the Puppy out for a walk » Suggestions
Modifying and Improving the ROX-filer
Moderators: Flash, Ian, JohnMurga
Post new topic   Reply to topic View previous topic :: View next topic
Page 6 of 8 [111 Posts]   Goto page: Previous 1, 2, 3, 4, 5, 6, 7, 8 Next
Author Message
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Sat 24 Sep 2016, 09:56    Post subject:  

"export LIBS=-lm" before compiling.

Rox-panel is a panel just like any other panel (lxpanel, wbar, etc). It's an application launcher. Its rather spartan but if you don't want to invest in another panel, Rox provides one for you.

_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
greengeek


Joined: 20 Jul 2010
Posts: 4712
Location: Republic of Novo Zelande

PostPosted: Sat 24 Sep 2016, 16:47    Post subject:  

greengeek wrote:
I would like to see rox filer modified to include an icon (on the top line) for the "create new directory" function.
I have changed my mind - I think it would be more useful to include an icon which brought up the rightclick context menu. That way "create new directory" function and a whole host of other functions would be available from that one icon.

This would be a great asset on touch screens.
(ok if you want to use keyboard shortcuts you can use the backslash key or the menu key to access the rightclick menu but it would be nice to have that ability direct from a touchscreen).
Back to top
View user's profile Send private message 
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Mon 26 Sep 2016, 20:29    Post subject:  

greengeek wrote:
I have changed my mind - I think it would be more useful to include an icon which brought up the rightclick context menu. That way "create new directory" function and a whole host of other functions would be available from that one icon.

This would be a great asset on touch screens.
(ok if you want to use keyboard shortcuts you can use the backslash key or the menu key to access the rightclick menu but it would be nice to have that ability direct from a touchscreen).


Patch attached.
james.patch.zip
Description 
zip

 Download 
Filename  james.patch.zip 
Filesize  781 Bytes 
Downloaded  67 Time(s) 

_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Mon 26 Sep 2016, 20:34    Post subject:  

This patch will make Rox run faster, especially if you're on a slow network.
remove-gethostbyname.patch.zip
Description 
zip

 Download 
Filename  remove-gethostbyname.patch.zip 
Filesize  1.1 KB 
Downloaded  68 Time(s) 

_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
greengeek


Joined: 20 Jul 2010
Posts: 4712
Location: Republic of Novo Zelande

PostPosted: Mon 26 Sep 2016, 21:11    Post subject:  

jamesbond wrote:
Patch attached.
Thank you. Can you give me a tip how to use this? It looks like something that needs to be introduced at compile time - is that correct? cheers
Back to top
View user's profile Send private message 
LazY Puppy


Joined: 21 Nov 2014
Posts: 2007
Location: Germany

PostPosted: Mon 26 Sep 2016, 21:14    Post subject:  

Downloaded source code of rox filer from https://github.com/jun7/rox-filer/

Tried to patch its filer.c by the use of james.patch.

It returned a file filer.c.rej.

The compiled version doesn't have the new button/icon to get the context menu.

What may I have done wrong here?

greengeek wrote:
jamesbond wrote:
Patch attached.
Thank you. Can you give me a tip how to use this? It looks like something that needs to be introduced at compile time - is that correct? cheers


Load the devx. It contains patch

Usage: patch orig-file patch-file

In terminal: patch --help gives more info

_________________
RSH

"you only wanted to work your Puppies in German", "you are a separatist in that you want Germany to secede from Europe" (musher0) Laughing

No, but I gave my old drum kit away for free to a music store collecting instruments for refugees! Wink
Back to top
View user's profile Send private message 
disciple

Joined: 20 May 2006
Posts: 6770
Location: Auckland, New Zealand

PostPosted: Mon 26 Sep 2016, 21:22    Post subject:  

When does it make it faster? Just when operating over a network?
_________________
If you have or know of a good gtkdialog application, please post a link here

Classic Puppy quotes

ROOT FOREVER
Back to top
View user's profile Send private message 
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Tue 27 Sep 2016, 02:16    Post subject:  

@disciple
Each time rox opens a window, or adding a pinboard icon, it will perform hostname lookup. If your network is slow, especially if you DNS resolution is slow, this will slows down Rox - a lot. Example: http://www.murga-linux.com/puppy/viewtopic.php?p=925418#925418 (see the bottom of Gobbi's post).

This patch removes that (unnecessary) DNS resolution by removing gethostbyname calls.

@RSH
The patch failed, so change was *not* applied. See what's inside filer.c.rej. Which version of rox-jun7 did you get?

@greengreek
As RSH said, you need to compile rox from source. Download rox filer source, apply the patch (cd rox-filer-source; patch -Np1 -i /path/to/patch-file.patch) and then compile.

_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
LazY Puppy


Joined: 21 Nov 2014
Posts: 2007
Location: Germany

PostPosted: Tue 27 Sep 2016, 08:42    Post subject:  

Quote:
Which version of rox-jun7 did you get?


I just downloaded the .zip from here (the green "Clone or download" button).

Content of filer.c.rej:
Code:
--- filer.h   2016-08-19 01:51:02.000000000 +1000
+++ filer.h   2016-09-27 10:12:20.173383116 +1000
@@ -215,5 +215,6 @@
 
 UnmountPrompt filer_get_unmount_action(const char *path);
 void filer_set_unmount_action(const char *path, UnmountPrompt action);
+gboolean filer_show_popup_menu(GtkWidget *widget, FilerWindow *filer_window);
 
 #endif /* _FILER_H */
--- toolbar.c   2016-08-04 20:45:50.000000000 +1000
+++ toolbar.c   2016-09-27 10:14:34.893386438 +1000
@@ -196,6 +196,10 @@
    {N_("Help"), GTK_STOCK_HELP, N_("Show ROX-Filer help"),
     toolbar_help_clicked, DROP_NONE, TRUE,
     FALSE},
+
+   {N_("Context Menu"), GTK_STOCK_INDEX, N_("Show ROX-Filer context menu"),
+    filer_show_popup_menu, DROP_NONE, TRUE,
+    FALSE},
 };


Do I need to change these path's manually in the your patch file?
Code:
diff -ur rox-old/ROX-Filer/src/filer.c rox-filer-jun7-git/ROX-Filer/src/filer.c
--- rox-old/ROX-Filer/src/filer.c   2016-09-24 23:16:08.703670506 +1000
+++ rox-filer-jun7-git/ROX-Filer/src/filer.c   2016-09-27 10:12:03.473382704 +1000

_________________
RSH

"you only wanted to work your Puppies in German", "you are a separatist in that you want Germany to secede from Europe" (musher0) Laughing

No, but I gave my old drum kit away for free to a music store collecting instruments for refugees! Wink
Back to top
View user's profile Send private message 
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Tue 27 Sep 2016, 09:25    Post subject:  

See recording attached. "master.zip" is the rox-jun7 download from github.
out2.gif
 Description   
 Filesize   6.14 KB
 Viewed   290 Time(s)

out2.gif


_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
LazY Puppy


Joined: 21 Nov 2014
Posts: 2007
Location: Germany

PostPosted: Tue 27 Sep 2016, 19:17    Post subject:  

After successfully applying the patch and compiling rox filer, the icons for the partitions at the desktop are gone. They are stored usually in /root/Choices/ROX-Filer/globicons.

All icons didn't show up anymore as drives or usb flash drives. Instead they are showing up as a blue directory with a gearwheel.

_________________
RSH

"you only wanted to work your Puppies in German", "you are a separatist in that you want Germany to secede from Europe" (musher0) Laughing

No, but I gave my old drum kit away for free to a music store collecting instruments for refugees! Wink
Back to top
View user's profile Send private message 
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Wed 28 Sep 2016, 05:58    Post subject:  

Two possible causes:
1. Don't copy the entire ROX-Filer folder. Just copy over the new ROX-Filer binary (inside ROX-Filer folder) to your original ROX-Filer location (usually /usr/local/apps/ROX-Filer).

2. I see you still use /root/Choices folder. This has been deprecated for at least 10 years. rox-filer-jun7 is a new development with tons of changes; I don't know if he drops support for the "Choices" folder altogether.
Perhaps its better if you start with a conservative version of Rox-Filer, e.g. here: http://repo.or.cz/w/rox-filer.git (this one is from Thomas Leonard, the original author of ROX Filer) or any other version which is about the same age as the one you're currently using (ask the developer of the PUppy version you use - he/she should be able to answer you and direct you to the source he user).
The patch should apply to the older Rox as well.

Good luck.

_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
LazY Puppy


Joined: 21 Nov 2014
Posts: 2007
Location: Germany

PostPosted: Wed 28 Sep 2016, 08:44    Post subject:  

Quote:
I see you still use /root/Choices folder. This has been deprecated for at least 10 years.

Laughing

Obviously I'm not the only one who doesn't have any information about deprecated /root/Choices/ROX-Filer directory.

It is still existing and in use in Puppy Linux up to Xenial64 7.0.7.

Quote:
Don't copy the entire ROX-Filer folder.

I just copied only the binary and restarted X.

Since I have a mouse with left-, right- and middle-button, I think I will stay with the originally installed versions of rox filer.

Thanks.

_________________
RSH

"you only wanted to work your Puppies in German", "you are a separatist in that you want Germany to secede from Europe" (musher0) Laughing

No, but I gave my old drum kit away for free to a music store collecting instruments for refugees! Wink
Back to top
View user's profile Send private message 
jamesbond

Joined: 26 Feb 2007
Posts: 3071
Location: The Blue Marble

PostPosted: Wed 28 Sep 2016, 09:28    Post subject:  

LazY Puppy wrote:
Quote:
I see you still use /root/Choices folder. This has been deprecated for at least 10 years.

Laughing

Obviously I'm not the only one who doesn't have any information about deprecated /root/Choices/ROX-Filer directory.

It is still existing and in use in Puppy Linux up to Xenial64 7.0.7.

LOL Laughing Barry didn't get the note, that's why Choices still exist until today.
https://github.com/rox-desktop/rox-filer/commit/6967aa47a48c2478319435fbfaf9fbabd39e1fba.
Look at the commit date Wink

Quote:
Since I have a mouse with left-, right- and middle-button, I think I will stay with the originally installed versions of rox filer.

Thanks.


Thanks you for playing too Cool

_________________
Fatdog64, Slacko and Puppeee user. Puppy user since 2.13.
Contributed Fatdog64 packages thread.
Back to top
View user's profile Send private message 
LazY Puppy


Joined: 21 Nov 2014
Posts: 2007
Location: Germany

PostPosted: Wed 28 Sep 2016, 11:04    Post subject:  

The page says:

Change over from CHOICESPATH to XDG_CONFIG_HOME and XDG_CONFIG...

Checked in tahr 602 XDG_CONFIG_HOME returns: /root/.config
Checked in tahr 602 XDG_CONFIG returns: nothing

Btw.: I was just wondering from my first look into the Puppy file system, why there are two directories for the Rox filer data to be stored at.

Some of my scripts are modifying the globicons file, so I made code into that scripts to have both globicons files (the one in /root/Choices/ROX-Filer plus the one in /root/.config/rox.sourceforge.net/ROX-Filer) existing with equal contents (first I made this into my LazY Remaster Suite). Laughing

_________________
RSH

"you only wanted to work your Puppies in German", "you are a separatist in that you want Germany to secede from Europe" (musher0) Laughing

No, but I gave my old drum kit away for free to a music store collecting instruments for refugees! Wink
Back to top
View user's profile Send private message 
Display posts from previous:   Sort by:   
Page 6 of 8 [111 Posts]   Goto page: Previous 1, 2, 3, 4, 5, 6, 7, 8 Next
Post new topic   Reply to topic View previous topic :: View next topic
 Forum index » Taking the Puppy out for a walk » Suggestions
Jump to:  

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You can download files in this forum


Powered by phpBB © 2001, 2005 phpBB Group
[ Time: 0.0678s ][ Queries: 14 (0.0107s) ][ GZIP on ]