Modifying and Improving the ROX-filer

Message

jamesbond · #76 Post by **jamesbond** » Sat 24 Sep 2016, 13:56

"export LIBS=-lm" before compiling.

Rox-panel is a panel just like any other panel (lxpanel, wbar, etc). It's an application launcher. Its rather spartan but if you don't want to invest in another panel, Rox provides one for you.

greengeek · #77 Post by **greengeek** » Sat 24 Sep 2016, 20:47

greengeek wrote:I would like to see rox filer modified to include an icon (on the top line) for the "create new directory" function.

I have changed my mind - I think it would be more useful to include an icon which brought up the rightclick context menu. That way "create new directory" function and a whole host of other functions would be available from that one icon.

This would be a great asset on touch screens.
(ok if you want to use keyboard shortcuts you can use the backslash key or the menu key to access the rightclick menu but it would be nice to have that ability direct from a touchscreen).

jamesbond · #78 Post by **jamesbond** » Tue 27 Sep 2016, 00:29

greengeek wrote:I have changed my mind - I think it would be more useful to include an icon which brought up the rightclick context menu. That way "create new directory" function and a whole host of other functions would be available from that one icon.

This would be a great asset on touch screens.
(ok if you want to use keyboard shortcuts you can use the backslash key or the menu key to access the rightclick menu but it would be nice to have that ability direct from a touchscreen).

Patch attached.

jamesbond · #79 Post by **jamesbond** » Tue 27 Sep 2016, 00:34

This patch will make Rox run faster, especially if you're on a slow network.

greengeek · #80 Post by **greengeek** » Tue 27 Sep 2016, 01:11

jamesbond wrote:Patch attached.

Thank you. Can you give me a tip how to use this? It looks like something that needs to be introduced at compile time - is that correct? cheers

LazY Puppy · #81 Post by **LazY Puppy** » Tue 27 Sep 2016, 01:14

Downloaded source code of rox filer from https://github.com/jun7/rox-filer/

Tried to patch its filer.c by the use of james.patch.

It returned a file filer.c.rej.

The compiled version doesn't have the new button/icon to get the context menu.

What may I have done wrong here?

greengeek wrote:
jamesbond wrote:Patch attached.
Thank you. Can you give me a tip how to use this? It looks like something that needs to be introduced at compile time - is that correct? cheers

Load the devx. It contains patch

Usage: patch orig-file patch-file

In terminal: patch --help gives more info

disciple · #82 Post by **disciple** » Tue 27 Sep 2016, 01:22

When does it make it faster? Just when operating over a network?

jamesbond · #83 Post by **jamesbond** » Tue 27 Sep 2016, 06:16

@disciple
Each time rox opens a window, or adding a pinboard icon, it will perform hostname lookup. If your network is slow, especially if you DNS resolution is slow, this will slows down Rox - a lot. Example: http://www.murga-linux.com/puppy/viewto ... 418#925418 (see the bottom of Gobbi's post).

This patch removes that (unnecessary) DNS resolution by removing gethostbyname calls.

@RSH
The patch failed, so change was *not* applied. See what's inside filer.c.rej. Which version of rox-jun7 did you get?

@greengreek
As RSH said, you need to compile rox from source. Download rox filer source, apply the patch (cd rox-filer-source; patch -Np1 -i /path/to/patch-file.patch) and then compile.

LazY Puppy · #84 Post by **LazY Puppy** » Tue 27 Sep 2016, 12:42

Which version of rox-jun7 did you get?

I just downloaded the .zip from here (the green "Clone or download" button).

Content of filer.c.rej:

Code: Select all

--- filer.h	2016-08-19 01:51:02.000000000 +1000
+++ filer.h	2016-09-27 10:12:20.173383116 +1000
@@ -215,5 +215,6 @@
 
 UnmountPrompt filer_get_unmount_action(const char *path);
 void filer_set_unmount_action(const char *path, UnmountPrompt action);
+gboolean filer_show_popup_menu(GtkWidget *widget, FilerWindow *filer_window);
 
 #endif /* _FILER_H */
--- toolbar.c	2016-08-04 20:45:50.000000000 +1000
+++ toolbar.c	2016-09-27 10:14:34.893386438 +1000
@@ -196,6 +196,10 @@
 	{N_("Help"), GTK_STOCK_HELP, N_("Show ROX-Filer help"),
 	 toolbar_help_clicked, DROP_NONE, TRUE,
 	 FALSE},
+
+	{N_("Context Menu"), GTK_STOCK_INDEX, N_("Show ROX-Filer context menu"),
+	 filer_show_popup_menu, DROP_NONE, TRUE,
+	 FALSE},
 };

Do I need to change these path's manually in the your patch file?

Code: Select all

diff -ur rox-old/ROX-Filer/src/filer.c rox-filer-jun7-git/ROX-Filer/src/filer.c
--- rox-old/ROX-Filer/src/filer.c	2016-09-24 23:16:08.703670506 +1000
+++ rox-filer-jun7-git/ROX-Filer/src/filer.c	2016-09-27 10:12:03.473382704 +1000

jamesbond · #85 Post by **jamesbond** » Tue 27 Sep 2016, 13:25

See recording attached. "master.zip" is the rox-jun7 download from github.

LazY Puppy · #86 Post by **LazY Puppy** » Tue 27 Sep 2016, 23:17

After successfully applying the patch and compiling rox filer, the icons for the partitions at the desktop are gone. They are stored usually in /root/Choices/ROX-Filer/globicons.

All icons didn't show up anymore as drives or usb flash drives. Instead they are showing up as a blue directory with a gearwheel.

jamesbond · #87 Post by **jamesbond** » Wed 28 Sep 2016, 09:58

Two possible causes:
1. Don't copy the entire ROX-Filer folder. Just copy over the new ROX-Filer binary (inside ROX-Filer folder) to your original ROX-Filer location (usually /usr/local/apps/ROX-Filer).

2. I see you still use /root/Choices folder. This has been deprecated for at least 10 years. rox-filer-jun7 is a new development with tons of changes; I don't know if he drops support for the "Choices" folder altogether.
Perhaps its better if you start with a conservative version of Rox-Filer, e.g. here: http://repo.or.cz/w/rox-filer.git (this one is from Thomas Leonard, the original author of ROX Filer) or any other version which is about the same age as the one you're currently using (ask the developer of the PUppy version you use - he/she should be able to answer you and direct you to the source he user).
The patch should apply to the older Rox as well.

Good luck.

LazY Puppy · #88 Post by **LazY Puppy** » Wed 28 Sep 2016, 12:44

I see you still use /root/Choices folder. This has been deprecated for at least 10 years.

Obviously I'm not the only one who doesn't have any information about deprecated /root/Choices/ROX-Filer directory.

It is still existing and in use in Puppy Linux up to Xenial64 7.0.7.

Don't copy the entire ROX-Filer folder.

I just copied only the binary and restarted X.

Since I have a mouse with left-, right- and middle-button, I think I will stay with the originally installed versions of rox filer.

Thanks.

jamesbond · #89 Post by **jamesbond** » Wed 28 Sep 2016, 13:28

LazY Puppy wrote:
I see you still use /root/Choices folder. This has been deprecated for at least 10 years.

Obviously I'm not the only one who doesn't have any information about deprecated /root/Choices/ROX-Filer directory.

It is still existing and in use in Puppy Linux up to Xenial64 7.0.7.

LOL

Barry didn't get the note, that's why Choices still exist until today.
https://github.com/rox-desktop/rox-file ... abd39e1fba.
Look at the commit date

Since I have a mouse with left-, right- and middle-button, I think I will stay with the originally installed versions of rox filer.

Thanks.

Thanks you for playing too

LazY Puppy · #90 Post by **LazY Puppy** » Wed 28 Sep 2016, 15:04

The page says:

Change over from CHOICESPATH to XDG_CONFIG_HOME and XDG_CONFIG...

Checked in tahr 602 XDG_CONFIG_HOME returns: /root/.config
Checked in tahr 602 XDG_CONFIG returns: nothing

Btw.: I was just wondering from my first look into the Puppy file system, why there are two directories for the Rox filer data to be stored at.

Some of my scripts are modifying the globicons file, so I made code into that scripts to have both globicons files (the one in /root/Choices/ROX-Filer plus the one in /root/.config/rox.sourceforge.net/ROX-Filer) existing with equal contents (first I made this into my LazY Remaster Suite).

greengeek · #91 Post by **greengeek** » Thu 29 Sep 2016, 07:26

Any tips how I go about downloading from the git page shown below? I clicked the clone/download button but nothing happened. I'm sure i have got stuff from git previously but can't seem to get anywhere with this today.

EDIT : - solved it. Seems like my old version of Firefox is no longer compatible with Git. Grabbed the master.zip using Slimjet browser instead. Skip my next post.

greengeek · #92 Post by **greengeek** » Thu 29 Sep 2016, 07:39

LazY Puppy wrote:
greengeek wrote: Can you give me a tip how to use this?
Load the devx. It contains patch

Usage: patch orig-file patch-file

In terminal: patch --help gives more info

Thanks. I tried this but I am probably doing the wrong thing. I tried to apply the patch directly to the ROX-Filer file that is in my /usr/local/Apps/ROX-Filer directory (I copied it to /root temporarily)

Code: Select all

# patch /root/ROX-Filer /root/james.patch
patching file /root/ROX-Filer
Hunk #1 FAILED at 4770.
1 out of 1 hunk FAILED -- saving rejects to file /root/ROX-Filer.rej
patching file /root/ROX-Filer
Hunk #1 FAILED at 215.
1 out of 1 hunk FAILED -- saving rejects to file /root/ROX-Filer.rej
patching file /root/ROX-Filer
Hunk #1 FAILED at 196.
1 out of 1 hunk FAILED -- saving rejects to file /root/ROX-Filer.rej
#

I feel stupid. Is it stupid to run patch against the ROX-Filer binary?

.rej file contains:

Code: Select all

--- filer.c	2016-09-24 23:16:08.703670506 +1000
+++ filer.c	2016-09-27 10:12:03.473382704 +1000
@@ -4770,3 +4770,8 @@
             GINT_TO_POINTER(action));
     save_learnt_mounts();
 }
+
+gboolean filer_show_popup_menu(GtkWidget *widget, FilerWindow *filer_window)
+{
+	return popup_menu(widget, filer_window);
+}
--- filer.h	2016-08-19 01:51:02.000000000 +1000
+++ filer.h	2016-09-27 10:12:20.173383116 +1000
@@ -215,5 +215,6 @@
 
 UnmountPrompt filer_get_unmount_action(const char *path);
 void filer_set_unmount_action(const char *path, UnmountPrompt action);
+gboolean filer_show_popup_menu(GtkWidget *widget, FilerWindow *filer_window);
 
 #endif /* _FILER_H */
--- toolbar.c	2016-08-04 20:45:50.000000000 +1000
+++ toolbar.c	2016-09-27 10:14:34.893386438 +1000
@@ -196,6 +196,10 @@
 	{N_("Help"), GTK_STOCK_HELP, N_("Show ROX-Filer help"),
 	 toolbar_help_clicked, DROP_NONE, TRUE,
 	 FALSE},
+
+	{N_("Context Menu"), GTK_STOCK_INDEX, N_("Show ROX-Filer context menu"),
+	 filer_show_popup_menu, DROP_NONE, TRUE,
+	 FALSE},
 };

greengeek · #93 Post by **greengeek** » Thu 29 Sep 2016, 08:15

OK, I managed to download the master.zip and tried to follow James howto compile and got the following response in the terminal:

Code: Select all

# cd /root/roxfix2/rox-filer-master/
# patch -Np1 -i /root/james.patch
patching file ROX-Filer/src/filer.c
Hunk #1 succeeded at 4682 (offset -88 lines).
patching file ROX-Filer/src/filer.h
patching file ROX-Filer/src/toolbar.c
# cd ROX-Filer
# ./AppRun --compile^C
ERROR from ./AppRun:
I cannot find an executable binary.
Trying to compile...
#

The ./AppRun part seemed to go haywire:

Code: Select all

AppRun terminal shows:

Compiling /root/roxfix2/rox-filer-master/ROX-Filer... please wait...
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for GCC version... 4.7.1
checking whether to disable pointer sign warning... yes
checking whether to disable stack protector... yes
checking that pkg-config runs... yes
checking that sm (version >= 1) is installed... yes
checking that gtk+-2.0 (version >= 2.12.0) is installed... yes
checking that libxml-2.0 (version >= 2.0.0) is installed... yes
checking that shared-mime-info (version >= 0.14) is installed... yes
checking if pango (version >= 1.1.2) is installed... yes; enabling better wrapping
checking how to run the C preprocessor... gcc -E
checking for X... libraries , headers 
checking for gethostbyname... yes
checking for connect... yes
checking for remove... yes
checking for shmat... yes
checking for IceConnectionNumber in -lICE... yes
checking whether file -b works... yes
checking for large file support... yes
checking for dirent.h that defines DIR... yes
checking for library containing opendir... none required
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/wait.h that is POSIX.1 compatible... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking mntent.h usability... yes
checking mntent.h presence... yes
checking for mntent.h... yes
checking sys/ucred.h usability... no
checking sys/ucred.h presence... no
checking for sys/ucred.h... no
checking sys/mntent.h usability... no
checking sys/mntent.h presence... no
checking for sys/mntent.h... no
checking apsymbols.h usability... no
checking apsymbols.h presence... no
checking for apsymbols.h... no
checking apbuild/apsymbols.h usability... no
checking apbuild/apsymbols.h presence... no
checking for apbuild/apsymbols.h... no
checking sys/statvfs.h usability... yes
checking sys/statvfs.h presence... yes
checking for sys/statvfs.h... yes
checking sys/vfs.h usability... yes
checking sys/vfs.h presence... yes
checking for sys/vfs.h... yes
checking wctype.h usability... yes
checking wctype.h presence... yes
checking for wctype.h... yes
checking libintl.h usability... yes
checking libintl.h presence... yes
checking for libintl.h... yes
checking sys/inotify.h usability... yes
checking sys/inotify.h presence... yes
checking for sys/inotify.h... yes
checking for an ANSI C-conforming const... yes
checking for uid_t in sys/types.h... yes
checking for size_t... yes
checking for gethostname... yes
checking for unsetenv... yes
checking for mkdir... yes
checking for rmdir... yes
checking for strdup... yes
checking for strtol... yes
checking for statvfs... yes
checking for statfs... yes
checking for mbrtowc... yes
checking for floor in -lm... yes
checking for dlsym in -ldl... yes
checking for gettext in -lintl... no
checking for getopt_long in -lgnugetopt... no
checking for getopt_long... yes
checking for attropen... no
checking for getxattr... yes
checking attr/xattr.h usability... yes
checking attr/xattr.h presence... yes
checking for attr/xattr.h... yes
checking sys/xattr.h usability... yes
checking sys/xattr.h presence... yes
checking for sys/xattr.h... yes
checking extracting version information... version 2.11
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: config.h is unchanged
rm -f *.o Makefile.bak
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o abox.o /root/roxfix2/rox-filer-master/ROX-Filer/src/abox.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o action.o /root/roxfix2/rox-filer-master/ROX-Filer/src/action.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o appinfo.o /root/roxfix2/rox-filer-master/ROX-Filer/src/appinfo.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o appmenu.o /root/roxfix2/rox-filer-master/ROX-Filer/src/appmenu.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o bind.o /root/roxfix2/rox-filer-master/ROX-Filer/src/bind.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o bookmarks.o /root/roxfix2/rox-filer-master/ROX-Filer/src/bookmarks.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o bulk_rename.o /root/roxfix2/rox-filer-master/ROX-Filer/src/bulk_rename.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o cell_icon.o /root/roxfix2/rox-filer-master/ROX-Filer/src/cell_icon.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o choices.o /root/roxfix2/rox-filer-master/ROX-Filer/src/choices.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o collection.o /root/roxfix2/rox-filer-master/ROX-Filer/src/collection.c
gcc -I. -I/root/roxfix2/rox-filer-master/ROX-Filer/src -DHAVE_CONFIG_H  -g -O2 -Wall -Wmissing-prototypes -Wno-pointer-sign -fno-stack-protector  -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 `pkg-config  --cflags gtk+-2.0 libxml-2.0 sm ice`   -c -o dir.o /root/roxfix2/rox-filer-master/ROX-Filer/src/dir.c
/root/roxfix2/rox-filer-master/ROX-Filer/src/dir.c: In function ‘insert_item’:
/root/roxfix2/rox-filer-master/ROX-Filer/src/dir.c:915:7: error: void value not ignored as it ought to be
make: *** [dir.o] Error 1
Compile failed
Press Return...

Am I even close?

phat7 · #94 Post by **phat7** » Thu 29 Sep 2016, 08:53

jamesbond wrote:Each time rox opens a window, or adding a pinboard icon, it will perform hostname lookup. If your network is slow, especially if you DNS resolution is slow, this will slows down Rox - a lot.

What happens when I'm not conncted. Will Rox be faster or even slower?

CatDude · #95 Post by **CatDude** » Thu 29 Sep 2016, 10:25

Hi

@ greengeek

greengeek wrote:OK, I managed to download the master.zip and tried to follow James howto compile and got the following response in the terminal:
Code: Select all
# cd /root/roxfix2/rox-filer-master/
# patch -Np1 -i /root/james.patch
patching file ROX-Filer/src/filer.c
Hunk #1 succeeded at 4682 (offset -88 lines).
patching file ROX-Filer/src/filer.h
patching file ROX-Filer/src/toolbar.c
# cd ROX-Filer
# ./AppRun --compile^C
ERROR from ./AppRun:
I cannot find an executable binary.
Trying to compile...
# 

I assume that you copied the commands as shown in jamesbond's out2.gif
If so, i believe that the command:

Code: Select all

./AppRun --compile^C

should actually be:

Code: Select all

./AppRun --compile

The ^C part comes from James doing a Ctrl+C in the terminal.
I'm sure James will confirm this (or not, if that's the case)

Hope this helps.

CatDude
.

(old)Puppy Linux Discussion Forum

(old)Puppy Linux Discussion Forum

Modifying and Improving the ROX-filer