Author |
Message |
muggins
Joined: 20 Jan 2006 Posts: 6747 Location: hobart
|
Posted: Fri 30 Jul 2010, 05:17 Post subject:
|
|
Hello battleshooter,
I just tried compiling it, on p4.3.1, using cmake-2.6.
Code: | cmake -D CMAKE_INSTALL_PREFIX="/usr" ./CMakeLists.txt |
Unfortunately it only got to 15%. Mainly I suspect because my qt4-4.3.2 is missing certain features. Which qt4 are you using?
|
Back to top
|
|
 |
battleshooter

Joined: 14 May 2008 Posts: 1381 Location: Australia
|
Posted: Fri 30 Jul 2010, 06:15 Post subject:
|
|
That sounds about right Muggins, that's where I got to too. I'm using a qt I compiled myself 4.6.3. It's not with everything, just what was needed for KDE4.
Was the error along these lines?
Code: | [ 15%] Building CXX object CMakeFiles/ComicMaster.dir/src/main.cpp.o
In file included from /root/comicmaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/PageFrame.h:26,
from /root/comicmaster/src/./KeyboardManager/PageHandler.h:26,
from /root/comicmaster/src/main.cpp:24:
/root/comicmaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/../../../PageManager/PageListManagerSingleton.h:28:7: error: no newline at end of file
make[2]: *** [CMakeFiles/ComicMaster.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/ComicMaster.dir/all] Error 2
make: *** [all] Error 2 |
According to some sites all that's needed is:
Quote: |
Open the file in an editor, go to the last line of the file, and hit enter to add a blank line to the end of the file. |
But I couldn't find the file in question to edit.
Anyway I asked Kumosan that because last time I compiled it in Quirky with a different source tar it didn't have these problems.
Using the readme instructions found in src, "qmake ComicMasterGlobal.pro" generates:
Code: |
In file included from ./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/PageFrame.h:26,
from ./KeyboardManager/PageHandler.h:26,
from main.cpp:24:
./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/../../../PageManager/PageListManagerSingleton.h:28:7: error: no newline at end of file
main.cpp:27:35: error: src/ComicMasterConfig.h: No such file or directory
main.cpp: In function 'int main(int, char**)':
main.cpp:72: error: 'ComicMaster_Version' was not declared in this scope
make[1]: *** [.obj/main.o] Error 1
make[1]: Leaving directory `/root/comicmaster/src'
make: *** [sub-ComicMaster-pro-make_default] Error 2 |
If I know which one is the correct way to compile I reckon I might be able to figure it out, maybe.
Battleshooter
_________________ LMMS 1.0.2, Ardour 3.5.389, Kdenlive 0.9.8
|
Back to top
|
|
 |
muggins
Joined: 20 Jan 2006 Posts: 6747 Location: hobart
|
Posted: Fri 30 Jul 2010, 07:09 Post subject:
|
|
No, the newline errors are a minor problem. I'll need to try again with a newer QT4 to resolve errors like:
Code: | In file included from /home/comicmaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/PageFrame.h:24,
from /home/comicmaster/src/./KeyboardManager/PageHandler.h:26,
from /home/comicmaster/src/main.cpp:24:
/home/comicmaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/./DatabaseManager/DATABASEDEFINITIONS.h:28:26: error: QSharedPointer: No such file or directory
In file included from /home/comicmaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/PageFrame.h:26,
from /home/comicmaster/src/./KeyboardManager/PageHandler.h:26,
from /home/comicmaster/src/main.cpp:24:
/home/comicmaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/../../../PageManager/PageListManagerSingleton.h:28:7: error: no newline at end of file
In file included from /home/comicmaster/src/main.cpp:22:
/home/comicmaster/src/ComicMaster.h:177: error: 'GestureType' in namespace 'Qt' does not name a type
|
|
Back to top
|
|
 |
muggins
Joined: 20 Jan 2006 Posts: 6747 Location: hobart
|
Posted: Fri 30 Jul 2010, 09:47 Post subject:
|
|
You were right...qute a few files missing newlines. This time I used Qt4-4.6.2 ,from Slax, and cmake made it to 60%...before a whole bunch of linkage errors showed up! Might have another look in a day or so.
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Fri 30 Jul 2010, 14:51 Post subject:
|
|
battleshooter wrote: | Hi Kumosan,
How does link you gave me compile, by qmake in the src directory or cmake . in the main folder?
Battleshooter |
Hello Battleshooter,
the version I gave you is totally useless. I found the database problem. It had nothing to do with Qt or sqlite at all. Version 0066 was the first version where I switched from qmake to cmake.... and botched it. A mistake in CMakeLists.txt prevented ComicMaster to create its sqlite-config files. Never noticed that on my machine since those files were still present from earlier versions.
I just uploaded version 0067 to sourceforge where I fixed this bug.
Please use the cmake in the main folder.
cmake .
make
make install
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Fri 30 Jul 2010, 15:49 Post subject:
|
|
muggins wrote: | Unfortunately it only got to 15%. Mainly I suspect because my qt4-4.3.2 is missing certain features. Which qt4 are you using? |
Oh my, never expected that many problems. Never watched others 'over the shoulder' when they tried to compile ComicMaster.
QSharedPointer: No such file or directory....
This class was introduced in Qt 4.5.
You need Qt 4.6. Since this is the latest stable version, which is out since December 2009, I never expected problems here.
Don't use the .pro files. They are not supported anymore and will be removed soon.
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Fri 30 Jul 2010, 15:52 Post subject:
|
|
muggins wrote: | You were right...qute a few files missing newlines. This time I used Qt4-4.6.2 ,from Slax, and cmake made it to 60%...before a whole bunch of linkage errors showed up! Might have another look in a day or so. |
Could you quote them? Qt4-4.6.2 is fine. I suspect missing boost. 0066 had still some boost dependencies, which I removed in 0067. And please stop using anything before 0067... it is useless.
|
Back to top
|
|
 |
battleshooter

Joined: 14 May 2008 Posts: 1381 Location: Australia
|
Posted: Sat 31 Jul 2010, 03:45 Post subject:
|
|
Hi Kumosan,
Using .0067, at 16%:
Code: | [ 16%] Building CXX object CMakeFiles/ComicMaster.dir/src/main.cpp.o
In file included from /root/ComicMaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/PageFrame.h:26,
from /root/ComicMaster/src/./KeyboardManager/PageHandler.h:26,
from /root/ComicMaster/src/main.cpp:24:
/root/ComicMaster/src/./KeyboardManager/../PluginCode/ComicDatabase/DatabaseCode/../../../PageManager/PageListManagerSingleton.h:28:7: error: no newline at end of file
make[2]: *** [CMakeFiles/ComicMaster.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/ComicMaster.dir/all] Error 2
make: *** [all] Error 2
|
What do you think it is?
_________________ LMMS 1.0.2, Ardour 3.5.389, Kdenlive 0.9.8
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Sat 31 Jul 2010, 05:48 Post subject:
|
|
I wish I knew...
Quote: | error: no newline at end of file |
.. is usually only a warning. And though I activated -Werror and -Wall, which should give me all warnings and treat them as errors, I never get this. What version of gcc do you use?
Only thing I can do is add newlines. Strange, for newer files, and PageListManagerSingleton.h is newer, the editor should have done this automatically.
Problem is, I can easily search for strings and characters in my project, but searching for the absence....
|
Back to top
|
|
 |
muggins
Joined: 20 Jan 2006 Posts: 6747 Location: hobart
|
Posted: Sat 31 Jul 2010, 05:54 Post subject:
|
|
All these files need a newline added:
src/PageManager/PageListManagerSingleton.h
src/PluginCode/SingletonAccess.cpp
src/CommonCode/PreparedQuery.cpp
src/FileManipulator/FileSelectorDialog/FileSelectorButtons/FileSelectorVerifyAction.cpp
src/ControlCenter/SearchPlate/SearchThread.cpp
src/FileManipulator/FileSelectorDialog/FileSelectorComponents/BookmarkTableModel.cpp
src/FileManipulator/FileSelectorDialog/FileSelectorComponents/PathNavigator.cpp
Then it compiles OK for me using p431 & QT4-4.6.2. Now I just need to bodgy up a supporting, minimal, QT4.
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Sat 31 Jul 2010, 06:11 Post subject:
|
|
Those bastards....
From:
http://www.spinics.net/lists/gcchelp/msg16707.html
Quote: | This is a long-standing complaint that usually results in people just
saying "fix your invalid source code" or "use a non-broken editor."
See PR14331 for some history. There have been patches suggested over
the years to add a -Wno-eof-newline option to disable the warning but
they never went in. However, earlier this year the discussion concluded
that it would be simpler just to remove the warning than to add an
option to disable it, and so if you use a recent 4.3 (mainline >=
2007-05-31) then you will no longer see the warning.
|
In other words, I can never see such a warning. However, you probably use an older gcc and get this warnings, which results due to the -Werror flag in an abort. I would hate to remove -Werror. This is one good method to keep code clean and warning free.
Can you edit the CMakeLists.txt files?
Change to line
Code: | ADD_DEFINITIONS( "-ansi -Werror -Wall -DQT_NO_DEBUG") |
to
Code: | ADD_DEFINITIONS( "-ansi -Wall -DQT_NO_DEBUG") |
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Sat 31 Jul 2010, 06:13 Post subject:
|
|
muggins wrote: | All these files need a newline added:
...
Then it compiles OK for me using p431 & QT4-4.6.2. Now I just need to bodgy up a supporting, minimal, QT4. |
Thanks, muggins, I will fix the code. To bad, there is not even an option to switch on the old warning.
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Sat 31 Jul 2010, 06:33 Post subject:
|
|
Did it.
Fixed all the files muggins showed me. Here is the new version:
http://comicmaster.git.sourceforge.net/git/gitweb.cgi?p=comicmaster/comicmaster;a=snapshot;h=3c785e305b411d64a7c398aea311cd57a6972856;sf=tgz
Sorry, I cannot test it myself. I just don't get the warnings.
|
Back to top
|
|
 |
battleshooter

Joined: 14 May 2008 Posts: 1381 Location: Australia
|
Posted: Sat 31 Jul 2010, 07:00 Post subject:
|
|
Nice job man, I'll try and test it more thouroughly tomorrow, for now, I have an error:
Code: | [ 61%] Building CXX object CMakeFiles/ComicMaster.dir/build/qrc_SQLite.cxx.o
Linking CXX executable bin/ComicMaster
/usr/local/Trolltech/Qt-4.6.3/lib/libQtCore.so: undefined reference to `inotify_init1@GLIBC_2.9'
/usr/local/Trolltech/Qt-4.6.3/lib/libQtCore.so: undefined reference to `pipe2@GLIBC_2.9'
/usr/local/Trolltech/Qt-4.6.3/lib/libQtNetwork.so: undefined reference to `accept4@GLIBC_2.10'
collect2: ld returned 1 exit status
make[2]: *** [bin/ComicMaster] Error 1
make[1]: *** [CMakeFiles/ComicMaster.dir/all] Error 2
make: *** [all] Error 2
|
I don't know if it's serious or easily fixed. I'll think about it more later. Just let you know where I'm at. I don't think it matters though, Muggins is already on the case and was able to compile it so there shouldn't be a problem.
Battleshooter
_________________ LMMS 1.0.2, Ardour 3.5.389, Kdenlive 0.9.8
|
Back to top
|
|
 |
kumosan
Joined: 28 Jul 2010 Posts: 14
|
Posted: Sat 31 Jul 2010, 07:33 Post subject:
|
|
Hmm, this does not look good at all. I forwarded you error message to the Qt mailinglist. I think it might be a too old glibc. Did you compile the Qt libs yourself, or did you download a binary package?
If you did not compile you Qt yourself, this would still be an option. Though I doubt that ComicMaster is actually worth that much effort.
|
Back to top
|
|
 |
|